Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for textured cool plate #6860

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Conversation

SoftFever
Copy link
Owner

@SoftFever SoftFever commented Sep 21, 2024

Description

Support textured cool plates like BigTree's CryoGrip Textured Coating Steel Sheet.
This allows users to adjust z offset for textured plates.

Screenshot 2024-09-22 at 1 30 32 AM Screenshot 2024-09-22 at 10 34 59 AM

@SoftFever SoftFever merged commit 99d4d09 into main Sep 22, 2024
15 checks passed
def = this->add("textured_cool_plate_temp", coInts);
def->label = L("Other layers");
def->tooltip = L("Bed temperature for layers except the initial one. "
"Value 0 means the filament does not support to print on the Textured Cool Plate");
Copy link

@pgifford pgifford Sep 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SoftFever Just copy the tooltip from the other plates because "the filament does not support to print on the Textured Cool Plate" is pretty bad English, maybe have a native speaker review PRs where English is added to the UI.

@igiannakas
Copy link
Contributor

Hey SF! Seems like the introduction of the new plate is causing some issues when opening a project for the second time.

See below:
Project saved with the textured PEI plate:
image

Opening the project again - engineering plate is selected
image

Selecting another printerL
image

Then going back to the original printer - textured cool plate selected
image

Basically its got amnesia :D Its forgetting the plate selection and the saved plate in the project.

@pgifford
Copy link

Basically its got amnesia :D Its forgetting the plate selection and the saved plate in the project.

I don’t think that’s quite right, the behavior follows a pattern and what plate you end up with depends on the plate saved in the project. Regardless of the bed type selected when a project is opened, the bed type changes to the one prior to the bed saved in the project. For example, if you open a project using “smooth PEI” bed type, “engineering” will always be selected.

Also, if you repeatedly hit the “New Project” button you’ll see the “bed type” dropdown step backwards through the list.

@SoftFever
Copy link
Owner Author

Hey SF! Seems like the introduction of the new plate is causing some issues when opening a project for the second time.

Basically its got amnesia :D Its forgetting the plate selection and the saved plate in the project.

haha, it decreases bed type idx by one every time.
Fixed in #6893

@SoftFever SoftFever deleted the feature/textured-cool-plate branch September 24, 2024 11:42
@igiannakas
Copy link
Contributor

Awesome 🎉🙏🏻🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants