Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Adaptive Pressure advance #5609

Merged
merged 77 commits into from
Jul 28, 2024
Merged

Enhancement: Adaptive Pressure advance #5609

merged 77 commits into from
Jul 28, 2024
+1,067 −15

Commits on Jun 6, 2024

  1. Adaptive Pressure advance options setup

    @igiannakas
    igiannakas committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    15d817c View commit details
    Browse the repository at this point in the history

  2. Dynamic PA - PCHIP interpolator code and tests

    @igiannakas
    igiannakas committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    c0aa34e View commit details
    Browse the repository at this point in the history

  3. Integrate dynamic PA with slicing code - emit new PA values per speed… 

    … change
    @igiannakas
    igiannakas committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    755539f View commit details
    Browse the repository at this point in the history

  4. Link adaptive PA to role change instead of speed change

    @igiannakas
    igiannakas committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    257cdeb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    8b72f44 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Adaptive PA - Alpha 2 

    Reduce the frequency of requested PA changes by introducing a "state" variable.
Implement user toggle for adapting PA for external walls for overhangs
    @igiannakas
    igiannakas committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    7364dfc View commit details
    Browse the repository at this point in the history

  2. Hide adaptive PA for overhangs

    @igiannakas
    igiannakas committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    62c1ce7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    f4bd8f0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    75ac45b View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2024

  1. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    6623beb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 8, 2024
    Configuration menu
    Copy the full SHA
    a379a09 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2024

  1. Convert Adaptive PA to use volumetric flow model and start preparing … 

    …for converting to Gcode post processor
    @igiannakas
    igiannakas committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    98c9f06 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 9, 2024
    Configuration menu
    Copy the full SHA
    00a2ac4 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Converted Dynamic PA to a post processing filter. Reverted changes in… 

    … GCode cpp and created tagging mechanism to allow filter to apply PA changes.
    @igiannakas
    igiannakas committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    a77b980 View commit details
    Browse the repository at this point in the history

  2. Removed adaptive PA for overhangs

    @igiannakas
    igiannakas committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    9b97d38 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2024

  1. Foundations for two dimensional adaptive PA based on acceleration and… 

    … volumetric flow speed
    @igiannakas
    igiannakas committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    26ba3b8 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Minor code cleanup and updating of tooltips

    @igiannakas
    igiannakas committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    1121b9e View commit details
    Browse the repository at this point in the history

  2. Renaming files for better clarity and generate classes documentation

    @igiannakas
    igiannakas committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    f3894e5 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 15, 2024
    Configuration menu
    Copy the full SHA
    940fc28 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2024

  1. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 16, 2024
    Configuration menu
    Copy the full SHA
    8f84d1b View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2024

  1. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7c974d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    015a5fa View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Update src/libslic3r/PrintConfig.cpp 

    Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
    @igiannakas @ElectricalBoy
    igiannakas and ElectricalBoy committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    f851d8e View commit details
    Browse the repository at this point in the history

  2. Update src/libslic3r/PrintConfig.cpp 

    Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
    @igiannakas @ElectricalBoy
    igiannakas and ElectricalBoy committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    8debf65 View commit details
    Browse the repository at this point in the history

  3. Update src/libslic3r/PrintConfig.cpp 

    Co-authored-by: ElectricalBoy <15651807+ElectricalBoy@users.noreply.github.com>
    @igiannakas @ElectricalBoy
    igiannakas and ElectricalBoy committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2363296 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    2617613 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Introduce average mm3_mm over the length of a multipath for adaptive PA

    @igiannakas
    igiannakas committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    100a3a4 View commit details
    Browse the repository at this point in the history

  2. Updates for multipath handling part 2

    @igiannakas
    igiannakas committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    23cfd5c View commit details
    Browse the repository at this point in the history

  3. Introduce average mm3_mm over the length of a multipath for adaptive PA

    @igiannakas
    igiannakas committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    e241172 View commit details
    Browse the repository at this point in the history

  4. Trigger PA evaluation more frequently to catch edge cases where speed… 

    … changes across islands of the same feature type.
    @igiannakas
    igiannakas committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    b1a2be4 View commit details
    Browse the repository at this point in the history

  5. Updates for multipath handling part 2

    @igiannakas
    igiannakas committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4d19173 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Adaptive PA: Implement average flow estimation on loops

    @igiannakas
    igiannakas committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    cf8c023 View commit details
    Browse the repository at this point in the history

  2. Code formatting

    @igiannakas
    igiannakas committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    aec4969 View commit details
    Browse the repository at this point in the history

  3. Fix adaptive PA not adapting for small disconnected external wall lin… 

    …e segments.
    @igiannakas
    igiannakas committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    cecd1ac View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Updated to take max print speed of upcoming feature to calculate new … 

    …PA value.

This is to resolve issue of incorrect PA value used when starting a new feature at an overhang.
    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b1bc6a7 View commit details
    Browse the repository at this point in the history

  2. Code clean up

    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    0c50606 View commit details
    Browse the repository at this point in the history

  3. Performance tuning

    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    062ba5d View commit details
    Browse the repository at this point in the history

  4. Further performance tuning by reducing use of regex commands in the n… 

    …ested loops and fix bug preventing gcode line output
    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    68dfa81 View commit details
    Browse the repository at this point in the history

  5. Further performance tuning and tweaks to stop searching for max speed… 

    … after the first travel move.
    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    b1cb6f3 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    7663e3a View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6f47b51 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Reduce debug information

    @igiannakas
    igiannakas committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    8729f57 View commit details
    Browse the repository at this point in the history

  2. Updated debug info

    @igiannakas
    igiannakas committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    1e24e3c View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c519742 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    41826e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Fix an issue on seams on specific models when wipe before external pe… 

    …rimeter was enabled. Also cleanup documentation and add new to-do's
    @igiannakas
    igiannakas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    152b0f2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    2825f8f View commit details
    Browse the repository at this point in the history

  3. Prepare for adaptive PA for overhangs, fix wipe bug & clean up code a… 

    …nd comments
    @igiannakas
    igiannakas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    4983a4f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    7c776c6 View commit details
    Browse the repository at this point in the history

  5. Initial commit for adapting PA when extruding fully overhanging perim… 

    …eters
    @igiannakas
    igiannakas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0f4aef5 View commit details
    Browse the repository at this point in the history

  6. Ignore wipe command when identifying current print speed

    @igiannakas
    igiannakas committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    821ffc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    5ea2de6 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jun 29, 2024
    Configuration menu
    Copy the full SHA
    50f2f01 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    35a64d4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    eef7c7e View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Option to evaluate adaptive PA on overhang regions in preparation for… 

    … Klipper experimental option testing
    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    79fbe3f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5747b7c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    35dc6d9 View commit details
    Browse the repository at this point in the history

  4. Update to issue PA changes for varying flow conditions within the sam… 

    …e feature
    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    bed4cc9 View commit details
    Browse the repository at this point in the history

  5. Fix bug where adaptive PA was enabled erroneously for role changes an… 

    …d ignoring user's preference.
    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b587205 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a646f30 View commit details
    Browse the repository at this point in the history

  7. Refactored some code

    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    6f01cf1 View commit details
    Browse the repository at this point in the history

  8. More refactoring

    @igiannakas
    igiannakas committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    57a2ab4 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. Merge branch 'main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    9ff4c69 View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Some bug fixes and enabled comments only when verbose g-code is enabled

    @igiannakas
    igiannakas committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    0a7429a View commit details
    Browse the repository at this point in the history

  2. Introduced dedicated PA option for bridges

    @igiannakas
    igiannakas committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    f0df6a7 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    27b9d75 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. Code refactoring to optimise initialisation of PA processor (making i… 

    …t faster). Fix a bug where PA was not always set after a toolchange. Improve general error handling and robustness.
    @igiannakas
    igiannakas committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    00ba09f View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    82ed6eb View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    bd37e13 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    24885ae View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. Updates to adaptive PA tooltips

    @igiannakas
    igiannakas committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    cf15c84 View commit details
    Browse the repository at this point in the history

  2. Bridging PA check with Epsilon instead of 0.

    @igiannakas
    igiannakas committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    60a4a13 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    d85a891 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'SoftFever:main' into Adaptive-Pressure-Advance

    @igiannakas
    igiannakas committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    4fdf79e View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Merge remote-tracking branch 'upstream/main' into Adaptive-Pressure-A… 

    …dvance
    @igiannakas
    igiannakas committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    64f1b60 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2024

  1. Adaptive PA: addressing comments

    @igiannakas
    igiannakas committed Jul 28, 2024
    Configuration menu
    Copy the full SHA
    487722a View commit details
    Browse the repository at this point in the history