Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails feature revamp. #5555

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Thumbnails feature revamp. #5555

merged 2 commits into from
Jun 3, 2024

Conversation

SoftFever
Copy link
Owner

Description

Support generating different size/format combinations,
We can now specify thumbnails like this: 380x380/COLPIC, 210x210/COLPIC, 380x380/PNG
This is useful for printers use multiply thumbnails for on device screen and web interface.
For example, Qidi X3 serial/Prusa MK4/MINI/Elegoo Neptune 4/etc...

Co-authored-by: Lukas Matena lukasmatena@seznam.cz

Screenshots/Recordings/Graphs

image
image

Tests

Tested with Voron 2.4/Prusa MK4

Support generating different size/format combinations
Co-authored-by: Lukas Matena <lukasmatena@seznam.cz>
@SoftFever SoftFever merged commit c083541 into main Jun 3, 2024
13 of 14 checks passed
@SoftFever SoftFever deleted the feature/thumbnail_revamp branch June 3, 2024 13:30
@kiniad
Copy link

kiniad commented Jun 19, 2024

Sorry, but this doesn't work on the Qidi X-Plus3 anymore.
The ;gimage: ... and ;simage:... section is required at the end of the gcode, as it was up to version 2.0.0.
Now the :gimage and ;simage are before the "; THUMBNAIL_BLOCK_START" and the X-Plus 3 doesn't show the image anymore.

@astrojolo
Copy link

astrojolo commented Jun 19, 2024

I confirm - still works on 2.1 beta, but not anymore on 2.1 RC.
UPDATE: also does not work on 2.1 final.

@kiniad
Copy link

kiniad commented Jul 1, 2024

UPDATE: Still does not work on 2.1.1
For the at least for Qidi X-Plus 3 the COLPIC (gimage, simage) have to be at the end of the gcode, as it was before.

@tome9111991
Copy link
Contributor

I can confirm not work on qidi x max3

@FMD14
Copy link

FMD14 commented Jul 16, 2024

Hello, it doesn't work on an ELEGOO Neptune 4 Pro either.

@ipod9138
Copy link

We need the "Format of G-code thumbnails" Drop down back to select ColPic we have no thumbnails on the X3 series....again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants