Fix model load in debug build #4656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full call stack for the assertion failed: |
Debug build exit with error on model load due to failed assertion (file
path redacted):
orca-slicer: <...>/OrcaSlicer/src/libslic3r/Model.cpp:1361: void Slic3r::ModelObject::update_min_max_z(): Assertion `! this->instances.empty()' failed.
Assertion failed due to model->ensure_on_bed() being called for object
which yet to be load from file.
Do not call ensure_on_bed() for models read from file since they may be
read with no default instance.
ensure_on_bed() called later within withing Plater::load_model_objects()
for each object added.
buzzhuzz
force-pushed
the
dbuzz/model-load-in-debug
branch
from
08505a1
to
4e46eb3
Compare
SoftFever
requested changes
Apr 3, 2024
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 10, 2024
* Fix model load in debug build
Debug build exit with error on model load due to failed assertion (file
path redacted):
orca-slicer: <...>/OrcaSlicer/src/libslic3r/Model.cpp:1361: void Slic3r::ModelObject::update_min_max_z(): Assertion `! this->instances.empty()' failed.
Assertion failed due to model->ensure_on_bed() being called for object
which yet to be load from file.
Do not call ensure_on_bed() for models read from file since they may be
read with no default instance.
ensure_on_bed() called later within withing Plater::load_model_objects()
for each object added.
* Rework according to code review comment
powpingdone
pushed a commit
to powpingdone/OrcaSlicer
that referenced
this pull request
Apr 11, 2024
* Fix model load in debug build
Debug build exit with error on model load due to failed assertion (file
path redacted):
orca-slicer: <...>/OrcaSlicer/src/libslic3r/Model.cpp:1361: void Slic3r::ModelObject::update_min_max_z(): Assertion `! this->instances.empty()' failed.
Assertion failed due to model->ensure_on_bed() being called for object
which yet to be load from file.
Do not call ensure_on_bed() for models read from file since they may be
read with no default instance.
ensure_on_bed() called later within withing Plater::load_model_objects()
for each object added.
* Rework according to code review comment
SoftFever
pushed a commit
that referenced
this pull request
Apr 13, 2024
* Fix model load in debug build
Debug build exit with error on model load due to failed assertion (file
path redacted):
orca-slicer: <...>/OrcaSlicer/src/libslic3r/Model.cpp:1361: void Slic3r::ModelObject::update_min_max_z(): Assertion `! this->instances.empty()' failed.
Assertion failed due to model->ensure_on_bed() being called for object
which yet to be load from file.
Do not call ensure_on_bed() for models read from file since they may be
read with no default instance.
ensure_on_bed() called later within withing Plater::load_model_objects()
for each object added.
* Rework according to code review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debug build exit with error on model load due to failed assertion (file path redacted):
Assertion failed due to model->ensure_on_bed() being called for object which yet to be load from file.
Do not call ensure_on_bed() for models read from file since they may be read with no default instance.
ensure_on_bed() called later within withing Plater::load_model_objects() for each object added.