Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking turned off, tracking indices still being created #1691

Closed
Thertor opened this issue Feb 5, 2020 · 4 comments
Closed

Tracking turned off, tracking indices still being created #1691

Thertor opened this issue Feb 5, 2020 · 4 comments
Assignees

Comments

@Thertor
Copy link

Thertor commented Feb 5, 2020

Preconditions

Magento Version : Magento 2.3.1 Communitry Edition and Magento 2.3.2 Enterprise

ElasticSuite Version : 2.8.2

Environment : Production mode

Elasticsearch: 6.8+

Steps to reproduce

  1. Setup elasticsuite
  2. Set tracking in the module to false
  3. Let people do search etc
  4. Tracking indices are still created and updated

Expected result

  1. Tracking indices shouldn't be created and update

Actual result

  1. Tracking indices are created and updated

This has happened with several of our M2 customers now, on different versions of Magento, the two best examples are both running the same elasticsuite version.

@rbayet
Copy link
Collaborator

rbayet commented Feb 6, 2020

Hello @Thertor,

Strange, this looks like #1252 (fixed in 2.6.6 and 2.7.4) is back ...
Are you sure that events dating from after the tracking is disabled end up in new Elasticsearch indices ?
This could be previous events clogging the DB storage table.

Regards,

@Thertor
Copy link
Author

Thertor commented Feb 7, 2020

Yes, the tracking was never enabled in the first place before I added these two to the ES cluster.

@no-response no-response bot removed the needs update label Feb 7, 2020
@Thertor Thertor removed their assignment Feb 7, 2020
@rbayet rbayet self-assigned this Feb 21, 2020
@rbayet
Copy link
Collaborator

rbayet commented Feb 24, 2020

Hello @Thertor,

Sorry, I cannot reproduce your issue in 2.8.2 or 2.8.4.
Once disabled, the tracker does not collect any new event, ie no new record is added to table elasticsuite_tracker_log_event.

On the other hand, as stated, if you still had some events dating from right before disabling the tracker in Stores > Configuration > Elasticsuite > Tracking, then any cron:run execution will indeed index those remaining events in the Elasticsearch server.
Hence my remark about

This could be previous events clogging the DB storage table.

We could probably decide not to index them at all and let them be in the storage DB table.

Something that bothers me, you say

Yes, the tracking was never enabled in the first place before I added these two to the ES cluster.

The tracking is enabled by default when installing the module, so it does not need to be explicitly enabled.
Were you saying that you had taken extra steps to make sure the tracking was disabled before deploying ?

Regards,

@rbayet rbayet removed their assignment Feb 27, 2020
@no-response
Copy link

no-response bot commented Mar 10, 2020

This issue was waiting update from the author for too long.
Without any update, we are unfortunately not sure how to resolve this issue.
We are therefore reluctantly going to close this bug for now. Please don't hesitate to comment on the bug if you have any more information for us; we will reopen it right away!
Thanks for your contribution.

@no-response no-response bot closed this as completed Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants