Skip to content
This repository has been archived by the owner on Jan 24, 2023. It is now read-only.

[nit] return false; when calling prevent default on event #252

Open
mrcnski opened this issue Feb 14, 2022 · 0 comments
Open

[nit] return false; when calling prevent default on event #252

mrcnski opened this issue Feb 14, 2022 · 0 comments

Comments

@mrcnski
Copy link
Contributor

mrcnski commented Feb 14, 2022

nit I think usually you want to call prevent default on the event, but you also want to return false here. I don't know why though unfortunately, I just know onsubmit="whatever(); return false" or onsubmit="return myValidator()" is a thing. Decided to leave the comment since it might be useful to you but feel free to just resolve if we don't care.

Originally posted by @peterjan in #188 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant