Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A problem with the letters "İ" in Turkish and "i" in English. #6426

Closed
1 task done
Mehmetturker50 opened this issue Feb 12, 2024 · 3 comments
Closed
1 task done

A problem with the letters "İ" in Turkish and "i" in English. #6426

Mehmetturker50 opened this issue Feb 12, 2024 · 3 comments
Assignees
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@Mehmetturker50
Copy link

Mehmetturker50 commented Feb 12, 2024

Skript/Server Version

> skript info
[21:52:34 INFO]: [Skript] Skript's aliases can be found here: https://github.com/SkriptLang/skript-aliases
[21:52:34 INFO]: [Skript] Skript's documentation can be found here: https://docs.skriptlang.org/
[21:52:34 INFO]: [Skript] Skript's tutorials can be found here: https://docs.skriptlang.org/tutorials
[21:52:34 INFO]: [Skript] Server Version: git-Paper-785 (MC: 1.16.5)
[21:52:34 INFO]: [Skript] Skript Version: 2.8.2 (skriptlang-github)
[21:52:34 INFO]: [Skript] Installed Skript Addons:
[21:52:34 INFO]: [Skript]  - SkImage v1.8
[21:52:34 INFO]: [Skript]  - Skellett v1.9.11 (https://forums.skunity.com/resources/skellett.24/)
[21:52:34 INFO]: [Skript]  - SkWaze v3.0.9
[21:52:34 INFO]: [Skript]  - skript-yaml v1.5
[21:52:34 INFO]: [Skript]  - MongoSK v2.3.0 (https://github.com/Romitou/MongoSK)
[21:52:34 INFO]: [Skript]  - MorkazSk v1.3
[21:52:34 INFO]: [Skript]  - skript-reflect v2.4 (https://github.com/SkriptLang/skript-reflect)
[21:52:34 INFO]: [Skript]  - skript-db v1.3.6
[21:52:34 INFO]: [Skript]  - SkQuery v4.1.10
[21:52:34 INFO]: [Skript]  - SkBee v1.15.3 (https://github.com/ShaneBeee/SkBee)
[21:52:34 INFO]: [Skript]  - SkJade v1.4.2 (https://github.com/Ankoki-Dev/SkJade)
[21:52:34 INFO]: [Skript]  - SkriptJSON v1.0.0
[21:52:34 INFO]: [Skript] Installed dependencies: None

Bug Description

If the Turkish letter "İ" is used twice in the same line, the script gives a "can't understand" error.

Expected Behavior

There shouldn't have been any errors.

Steps to Reproduce

this will giving error:
send "İİ" to player
this will not giving error:
send "İi" to player
and this will not giving error too:
send "ii" to player

Errors or Screenshots

image

Other

No response

Agreement

  • I have read the guidelines above and affirm I am following them with this report.
@sovdeeth sovdeeth added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Feb 12, 2024
@APickledWalrus APickledWalrus added the investigating The core developers are currently investigating this issue. Usually used for complex cases. label Feb 15, 2024
@APickledWalrus APickledWalrus self-assigned this Feb 15, 2024
@Moderocky
Copy link
Member

I think I recognise this, I'm pretty sure we had a similar (if not identical) issue in the past and it had something to do with the encoding and the escaping/closing of the string.

@AyhamAl-Ali
Copy link
Member

We fixed this before by using Locale.ENGLISH but not sure how this is still occuring.

@APickledWalrus APickledWalrus removed the investigating The core developers are currently investigating this issue. Usually used for complex cases. label Feb 22, 2024
@APickledWalrus
Copy link
Member

This problem occurs in some places in the parser where toLowerCase() is used. These places falsely assume that string.length() == string.toLowerCase(Locale.ENGLISH).length() which is not guaranteed (notably for the character this issue mentions).

@APickledWalrus APickledWalrus added the PR available Issues which have a yet-to-be merged PR resolving it label Feb 22, 2024
@sovdeeth sovdeeth added the patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. label Feb 22, 2024
@APickledWalrus APickledWalrus added completed The issue has been fully resolved and the change will be in the next Skript update. and removed PR available Issues which have a yet-to-be merged PR resolving it labels Mar 1, 2024
@sovdeeth sovdeeth closed this as completed Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. patch-ready A PR/issue that has been approved and is ready to be merged/closed for the next patch version. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Development

No branches or pull requests

5 participants