Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skript use mod item #4051

Closed
RuNan2 opened this issue Jun 2, 2021 · 14 comments
Closed

skript use mod item #4051

RuNan2 opened this issue Jun 2, 2021 · 14 comments
Labels
invalid Not a Skript issue, already implemented, does not apply, etc.

Comments

@RuNan2
Copy link

RuNan2 commented Jun 2, 2021

Description

Skript 2.6alpha how can I use mod item in skript

Steps to Reproduce

Expected Behavior

aliases:
plus = 4521
minus = 4522

Errors / Screenshots

[23:10:15] [Server thread/ERROR] [Mohist]: Minecraft id 4522 is not valid (은행.sk, line 55: minus: 4522')

Server Information

  • Server version/platform:
  • Skript version:
    mohist 1.12.2 lastest
    skript 2.6 alpha

Additional Context

@ShaneBeee
Copy link
Contributor

You need to use a valid namespace.
Skript no longer uses numerical IDs for items

@TPGamesNL TPGamesNL added the waiting for reply The report needs a response from the reporter to determine course of action. label Jun 2, 2021
@RuNan2
Copy link
Author

RuNan2 commented Jun 2, 2021

I do 4522 --> numbermod minus but I can't
[01:34:50 ERROR]: [Skript] Minecraft id numbermod minus is not valid (은행.sk, line 55: minus: numbermod minus')

@RuNan2 RuNan2 closed this as completed Jun 2, 2021
@RuNan2 RuNan2 reopened this Jun 2, 2021
@ShaneBeee
Copy link
Contributor

I just realized Skript does not support modding.

You would need to use a valid namespace, ie: modname:namespace but Skript only supports the Minecraft namespace

Closing due to this not actually being an issue, we just dont offer any support for mods right now.

@RuNan2
Copy link
Author

RuNan2 commented Jun 2, 2021

In Skiprt 2.2dev37 We had a mod item available.

@TPGamesNL TPGamesNL added invalid Not a Skript issue, already implemented, does not apply, etc. and removed waiting for reply The report needs a response from the reporter to determine course of action. labels Jun 2, 2021
@ShaneBeee
Copy link
Contributor

Yes, Im very well aware.
But due to the changes in Minecraft 1.13, we dropped supporting numerical IDs

Feel free to continue using Skript 2.2, but I repeat, we do not currently offer support for mods

@RuNan2
Copy link
Author

RuNan2 commented Jun 2, 2021

Then, is there any way to support the ID only for mod items?

@ShaneBeee
Copy link
Contributor

yeah, by using 2.2
I already said this

@RuNan2
Copy link
Author

RuNan2 commented Jun 2, 2021

Then, is there no support for mod items from now on? Many development communities in Korea want it.

@ShaneBeee
Copy link
Contributor

Come Skript 2.7, we are dropping 1.12.2 and below support.
We will not go backwards in time and re-add support for numeric IDs, since the use of numeric IDs was dropped years ago.

As for offering support for mod namespaces, it has been talked about, and may be added in the future.
But due to the way we use namespaces in the internal code, and the work that would have to be done to restructure all of this, this is a very very low priority to the Skript dev team.

As stated, if you need this kind of support, please feel free to use Skript 2.2

@FranKusmiruk
Copy link
Member

FranKusmiruk commented Jun 2, 2021

Skript doesn't officially support mods, that being said there are Bukkit forks which allow you to use them. There has been a recent PR which added support for dynamic enum values (this was an issue for Mohist/CatServer when registering aliases) so you should be able to use numbermod:minus or whatever the item namespace is just fine but whether it works or not is not guaranteed nor supported by us.

If it doesn't work, PRs to solve the issue are welcome as long as they don't impose a maintenance burden on our current codebase.

@RuNan2
Copy link
Author

RuNan2 commented Jun 3, 2021

What lastest version support Item ID

@RuNan2
Copy link
Author

RuNan2 commented Jun 3, 2021

And I think it will be a mod item through Skript Aliases, is it possible?

@AyhamAl-Ali
Copy link
Member

AyhamAl-Ali commented Jun 3, 2021

What lastest version support Item ID

You would need Skript 2.2-dev36 (because dev37c had a memory leak afair)

And I think it will be a mod item through Skript Aliases, is it possible?

As the devs stated above, it might be added in the future but no plans for that yet. However, as Frank said, PRs to solve the issue are welcome as long as they don't impose a maintenance burden on our current codebase.

@RuNan2
Copy link
Author

RuNan2 commented Jun 5, 2021

Did you happen to have any problems other than memory leaks in skript 2.2-dev37c? compared to dev36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Not a Skript issue, already implemented, does not apply, etc.
Projects
None yet
Development

No branches or pull requests

5 participants