Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event-item bug #2771

Closed
short509 opened this issue Jan 15, 2020 · 15 comments
Closed

event-item bug #2771

short509 opened this issue Jan 15, 2020 · 15 comments
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: high Issues with potentially high impact that could be harmful to users.
Milestone

Comments

@short509
Copy link

short509 commented Jan 15, 2020

Description

"event-item" which worked well in version 2.4, does not work.

Steps to Reproduce

on rightclick:
       if player is sneaking:
               message "%type of event-item%" to player

Errors / Screenshots

2020-01-16_07 05 59

Server Information

  • Server version/platform: 1.15.1
  • Skript version: 2.5-alpha
@Wealthyturtle Wealthyturtle added the needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. label Jan 16, 2020
@APickledWalrus
Copy link
Member

I did some testing, and this only seems to be an issue with click events. The issue is that the event-item is returning no value, not the type expression.

@iOshawott
Copy link

well in my skripts
"set {_y} to number of event-item in player's inventory"
doesn't work too :(

@short509
Copy link
Author

short509 commented Feb 2, 2020

well in my skripts
"set {_y} to number of event-item in player's inventory"
doesn't work too :(

"event-item" seems to be the problem.

@Misio12320
Copy link

Give there a priority and event-entity, does not work too

@iOshawott
Copy link

iOshawott commented Feb 9, 2020

have a Hope this, 2714 and 2802 will be fixed in next release

@TheLimeGlass
Copy link
Collaborator

Duplicate #2736

@bensku
Copy link
Member

bensku commented Feb 25, 2020

@TheLimeGlass No, this is separate issue that may be caused by same underlying issue.

@ShaneBeee
Copy link
Contributor

I think the "issue" here is whether or not you consider this an issue.

Prior versions, event-item returned the player's tool.
Whereas now it returns the item type you clicked on.
In this case, you didn't click on anything, hence it being none.
If you right-clicked on grass it would return grass.

Now, in my option, I think this way makes more sense.
event-item = clicked block
player's tool = thing in hand.

Personally I wouldn't classify this as a bug, but maybe a change for the better?
I guess the "issue" here is that it changed, which could potentially break scripts.

@bensku
Copy link
Member

bensku commented Mar 3, 2020

Event item used to give the item that was activated by clicking, which could be offhand item too.

@iOshawott
Copy link

iOshawott commented Mar 5, 2020

https://pastebin.com/Dxxpc2MA

With event-item doesn't work porperly you can't get "set {_y} to number of event-item in player's inventory" - changing it to number of player's tool causes issue, that it can't be more than one and breaks this checks system which works good on 2.4

@Misio12320
Copy link

?!??? How its still need-testing??? Its a bug, go and fix it.

@iOshawott
Copy link

I hope it'll get fixed and then I'll update from 2.4.1 ;|

@ShaneBeee
Copy link
Contributor

?!??? How its still need-testing??? It's a bug, go and fix it.

I don't even know hot to reply to you. Your utter rudeness and sheer ignorance is really bothering me, and some others.
This is an open source project, please feel free to fix it and submit a PR.

@Misio12320
Copy link

Misio12320 commented Apr 26, 2020

?!??? How its still need-testing??? It's a bug, go and fix it.

I don't even know hot to reply to you. Your utter rudeness and sheer ignorance is really bothering me, and some others.

I got little rage because Dev of SkQuery has answer me after 2 months of my report bug and said "this is Skript bug". And there is still no update in mean need-testing. Its again my fault because your arguments are not possible to break. Apologies.

This is an open source project, please feel free to fix it and submit a PR.

Good to know.

@APickledWalrus APickledWalrus added priority: high Issues with potentially high impact that could be harmful to users. bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. and removed needs testing Needs testing to determine current status or issue validity, or for WIP feature pulls. labels Jul 10, 2020
@APickledWalrus APickledWalrus added this to the 2.5 milestone Jul 10, 2020
@APickledWalrus
Copy link
Member

This is still a present issue. event-item is returning the wrong value, and this may have broke many scripts.

@FranKusmiruk FranKusmiruk added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: high Issues with potentially high impact that could be harmful to users.
Projects
None yet
Development

No branches or pull requests

9 participants