Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for minecraft's native IDs and data #2547

Closed
bluelhf opened this issue Oct 10, 2019 · 7 comments
Closed

Support for minecraft's native IDs and data #2547

bluelhf opened this issue Oct 10, 2019 · 7 comments
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).

Comments

@bluelhf
Copy link
Contributor

bluelhf commented Oct 10, 2019

Suggestion

Description

Since Skript aliases are mapped to Minecraft's IDs anyways, I think it'd be a great (yet time-consuming) enhancement to allow players to use minecraft's native IDs as a replacement for aliases.

@ShaneBeee
Copy link
Contributor

ShaneBeee commented Oct 10, 2019

I'm curious why you feel this should be added?
In my opinion it serves no purpose, but I would love to hear a case as to why this would be needed.

Here is why I vote no, you can easily create your own aliases within a script, ex:

aliases:
    my item = minecraft:stone

command /test:
    trigger:
        give player 1 of my item

@bluelhf
Copy link
Contributor Author

bluelhf commented Oct 10, 2019

@ShaneBeee

  • It would clear confusion about aliases for people who've been using the native alias system for a while
  • Skript wouldn't have to deal with mapping arbitrary strings to IDs
  • Aside from the big ID changes in the introduction of blockstates, IDs have stayed fairly similar for many versions, and I believe they will in the future => less work for Skript developers

@ShaneBeee
Copy link
Contributor

Skript wouldn't have to deal with mapping arbitrary strings to IDs

Are you meaning abolish the alias system all together?
Personally I think this will never happen. If you look at the aliases, theres a lot of really weird specific things, ex: stairs, because they have many states, including up/down, direction, waterlogged. That said a user would have to know all the different block state types, ie:

set block at player to minecraft:oak_stairs[waterlogged=true,half=top,shape=inner_left]

etc...
Ps, I had to spend a few minutes going thru the aliases to figure out block data for stairs, this just goes to show it wouldnt be a very easy system to deal with for users.

IF you were suggesting the addition of this (on top of aliases), I would understand, but straight up abolishing the alias system I feel would be a no go.
At the end of the day, it would break every single script out there, plus it would make using items extremely difficult.

@Wealthyturtle
Copy link
Member

Wealthyturtle commented Oct 10, 2019

Abolishing the current alias system is definitely not a good idea... however if you mean adding Minecraft native IDs as an alias to Skript, e.g. using minecraft:diamond in scripts is equivalent to using diamond, then I think that's valid

@bluelhf
Copy link
Contributor Author

bluelhf commented Oct 10, 2019

@ShaneBeee I don't mean abolishing the current system. Sorry for any confusion!

@ShaneBeee
Copy link
Contributor

@ShaneBeee I don't mean abolishing the current system. Sorry for any confusion!

No need to apologize, but thank you for the clarification.

@ShaneBeee ShaneBeee added enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements). labels Oct 10, 2019
@bensku
Copy link
Member

bensku commented Oct 10, 2019

I'm not sure if this is a good idea, because Minecraft ids change between versions.

@ShaneBeee ShaneBeee added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something. priority: lowest "Nice to have" updates that are not required (tiny low impact bug fixes or QoL enhancements).
Projects
None yet
Development

No branches or pull requests

4 participants