Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-flattening aliases break when one MC ID maps to multiple Bukkit materials (wheat, skull, etc.) #2394

Closed
ICT-000 opened this issue Aug 24, 2019 · 7 comments
Closed

Pre-flattening aliases break when one MC ID maps to multiple Bukkit materials (wheat, skull, etc.) #2394

ICT-000 opened this issue Aug 24, 2019 · 7 comments
Assignees
@TheBentoBox
Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).

Comments

@ICT-000
Copy link

ICT-000 commented Aug 24, 2019

Description

Skript aliases! Wheat aliases do not work!

Steps to Reproduce

on break:
send "%event-block%"

Expected Behavior

It should throw out "rise wheat" not CROPS when I break it. Same problem with skull.

Errors / Screenshots

No console errors!

Server Information

Spigot 1.12.2 latest
Skript 2.4-beta3
@ham1255
Copy link

ham1255 commented Aug 24, 2019

get skript 2.4-beta5 cuase beta3 is old

@ham1255
Copy link

ham1255 commented Aug 24, 2019

https://github.com/SkriptLang/Skript/releases/download/2.4-beta5/Skript.jar

@ICT-000
Copy link
Author

ICT-000 commented Aug 24, 2019

Same problem

@ICT-000
Copy link
Author

ICT-000 commented Aug 24, 2019

Please fix that

@ghost
Copy link

ghost commented Aug 25, 2019

2.4-beta3 is so recent there really isn't a difference anyways. Will test this out later

@TheBentoBox TheBentoBox self-assigned this Aug 26, 2019
@TheBentoBox
Copy link
Member

Will investigate.

@TPGamesNL TPGamesNL mentioned this issue Aug 31, 2019
Closed
@TheBentoBox TheBentoBox changed the title Aliases fatal problem with wheat and skull Pre-flattening aliases break when multiple MC IDs map to one material (wheat, skull, etc.) Sep 2, 2019
@TheBentoBox TheBentoBox changed the title Pre-flattening aliases break when multiple MC IDs map to one material (wheat, skull, etc.) Pre-flattening aliases break when one MC ID maps to multiple Bukkit material (wheat, skull, etc.) Sep 2, 2019
@TheBentoBox TheBentoBox changed the title Pre-flattening aliases break when one MC ID maps to multiple Bukkit material (wheat, skull, etc.) Pre-flattening aliases break when one MC ID maps to multiple Bukkit materials (wheat, skull, etc.) Sep 2, 2019
@TheBentoBox
Copy link
Member

I've spoken with bensku about this and this is due to a single bug in how aliases work right now: they are unable to handle when one Minecraft ID maps to multiple different Bukkit materials. Currently there is no way to address this from the alias configs and it is handled in the code case-by-case. Hopefully the devs can address that limitation or make those overrides configurable in the future.

Point being, this isn't something I can fix and isn't an issue in the aliases themselves.

@TheBentoBox TheBentoBox added bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation). labels Sep 2, 2019
This was referenced Sep 2, 2019
Closed
Closed
Closed
@ShaneBeee ShaneBeee mentioned this issue Oct 24, 2019
Merged
@Wealthyturtle Wealthyturtle added the completed The issue has been fully resolved and the change will be in the next Skript update. label Oct 26, 2019
@bensku bensku closed this as completed Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheBentoBox TheBentoBox

Labels
bug An issue that needs to be fixed. Alternatively, a PR fixing an issue. completed The issue has been fully resolved and the change will be in the next Skript update. priority: medium Issues that are detrimental to user experience (prohibitive bugs or lack of useful implementation).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bensku @TheBentoBox @Wealthyturtle @ham1255 @ICT-000