Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Filters] Fix hitting max call depth when appliedFilters is undefined #10711

Merged
merged 1 commit into from
Sep 27, 2023
Merged

[Filters] Fix hitting max call depth when appliedFilters is undefined #10711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/seven-apricots-provide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@shopify/polaris': patch
---

Fixed issue with setting local pinned filters in `Filters` when no `appliedFilters` were provided.
6 changes: 3 additions & 3 deletions polaris-react/src/components/Filters/Filters.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,9 @@ export function Filters({
);

useEffect(() => {
const allAppliedFilterKeysInLocalPinnedFilters = appliedFilterKeys?.every(
(value) => localPinnedFilters.includes(value),
);
const allAppliedFilterKeysInLocalPinnedFilters =
!appliedFilterKeys ||
appliedFilterKeys.every((value) => localPinnedFilters.includes(value));

if (!allAppliedFilterKeysInLocalPinnedFilters) {
setLocalPinnedFilters((currentLocalPinnedFilters: string[]): string[] => {
Expand Down