Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Class Issue. #9

Closed
johnsonab opened this issue Apr 21, 2017 · 4 comments
Closed

CSS Class Issue. #9

johnsonab opened this issue Apr 21, 2017 · 4 comments

Comments

@johnsonab
Copy link

Issue summary

The Polaris-ResourceList__Item--persistActions class suggested in the docs for the ResourceList component does not match the CSS class in the styles.scss file that's generated.

Expected behavior

CSS should use Polaris-ResourceList__Item--persistActions

Actual behavior

CSS is using Polaris-ResourceList__Item-persistActions.

Steps to Reproduce the Problem

Try to implement a ResourceList item with actions and it will not show the actions since the CSS to unhide the element never gets applied.

Specifications

  • Polaris version: 1.0.0
@lemonmade
Copy link
Member

Thanks for the issue, @johnsonab. I've added this to our internal issue tracker to resolve in our next release. I'll close this issue once it's resolved.

@johnsonab
Copy link
Author

Hey @lemonmade. I'm finding this same problem in several areas. The compiled CSS using a single hyphens instead of double hyphens on the modifier.

Right: .Polaris-Some__Item--active

Wrong: .Polaris-Some__Item-active

Not sure this is a problem in your compiling that is fixed globally or if I should submit issues for each I find?

@ry5n
Copy link
Contributor

ry5n commented Apr 24, 2017

@johnsonab Yeah, this was a global thing–we’ve corrected it now in our development repo. You should see this fixed across the board in the next release.

@johnsonab
Copy link
Author

@ry5n great, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants