Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs not collapsing when inside a AnnotatedSection element #75

Closed
cargix1 opened this issue May 31, 2017 · 2 comments
Closed

Tabs not collapsing when inside a AnnotatedSection element #75

cargix1 opened this issue May 31, 2017 · 2 comments

Comments

@cargix1
Copy link

cargix1 commented May 31, 2017

Issue summary

When using Tabs within an <Layout.AnnotatedSection> element they don't collapse as they should when you reach mobile screen size.

Expected behavior

I'd expect the tabs to collapse like shown in the documentation.

screen shot 2017-05-31 at 17 20 43

Actual behavior

When I shrink my browser the tabs don't collapse causing the content to breakout as shown in the attached screenshot.

screen shot 2017-05-31 at 17 18 04

Steps to Reproduce the Problem

Place a Tabs element instead a Layout.AnnotatedSection element as shown below and resize your browser.

<Layout>
  <Layout.AnnotatedSection
    title="Store details"
    description="Shopify and your customers will use this information to contact you."
  >
    <Card sectioned>
      <Tabs
        fitted
        selected={0}
        tabs={[
          {
            id: 'all-customers',
            title: 'All',
            panelID: 'all-customers-content',
          },
          {
            id: 'accepts-marketing',
            title: 'Accepts marketing',
            panelID: 'accepts-marketing-content',
          },
          {
            id: 'not-accept-marketing',
            title: 'Not accept marketing',
            panelID: 'not-accept-marketing-content',
          }
        ]}
      />
    </Card>
  </Layout.AnnotatedSection>
</Layout>

Specifications

  • Polaris version: 1.0.3
  • React version: 15.4.2
  • Browser: Chrome, Safari, Firefox (latest stable)
  • Device: Macbook Pro
  • Operating System: Mac OS
@lemonmade
Copy link
Member

Confirmed that this is happening, we should have a fix out by the end of the week. I'll close this issue once we cut the new release.

@lemonmade
Copy link
Member

Should be fixed by v1.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants