-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs taking keypress focus #74
Comments
Thanks for the issue, @alexdover, confirmed that this is indeed happening. I'll have a fix up in the next version, which I am hoping to release on Friday. Will close this issue once it's addressed. |
OK, thanks - at least it wasn't just a newbie issue! |
Should be fixed by v1.1.0 |
Great, thanks! |
I just upgraded to polaris v1.1.1 Still having this issue. |
@cbodtorf can you provide some markup that exhibits this issue? I am unable to reproduce. |
Issue summary
I'm using the tabs component to render a settings page which has multiple forms. The documentation is a little light on how to code up the panel contents, but I have used onSelect to toggle between the forms I have.
What I have now found and can't seem to stop is that every time I press a key in the forms, the tabs grab the focus.
I am new to React so apologies if I am missing something obvious!
Expected behavior
When completing a form on the page the tabs do not take the focus.
Actual behavior
Typing into a field on the same page as a tab sees tab take the focus
Steps to Reproduce the Problem
Specifications
NOTE: This repo is only used for reporting issues and new feature requests. We are not accepting pull requests at this point in time.
The text was updated successfully, but these errors were encountered: