Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Icon] Update Tablet icon design #12452

Closed
wants to merge 4 commits into from
Closed

[Icon] Update Tablet icon design #12452

wants to merge 4 commits into from

Conversation

trtri2
Copy link
Contributor

@trtri2 trtri2 commented Jul 25, 2024

WHY are these changes introduced?

part of https://github.com/Shopify/retail-hq-store-management/issues/558

exported the icon SVG from this figma

  • Update the tablet icon to the new design (it was previously too similar to the mobile icon to distinguish the two)

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

update tableicon yml
@alex-page
Copy link
Member

@trtri2 what is the timeline and need for this adjustment? Can this wait? We are rebuilding the icon library right now.

@trtri2
Copy link
Contributor Author

trtri2 commented Jul 25, 2024

@trtri2 what is the timeline and need for this adjustment? Can this wait? We are rebuilding the icon library right now.

Hey @alex-page.

We received some UX feedback on one of our POS app UI editors, where you can change device preview to mobile or tablet.
Currently, the two icons are nearly indistinguishable. Ideally we'd like to have this improvement in sooner rather than later, but it's non-critical so shouldn't be a blocker for it.

image

If we were to wait for this rebuild, do you have a timeline/estimate on that which I can communicate to my team and let them know?

@alex-page
Copy link
Member

@trtri2 please review the 16x16 viewbox in this PR https://github.com/Shopify/admin-ui-foundations/pull/660

@trtri2
Copy link
Contributor Author

trtri2 commented Aug 27, 2024

Closing in favour for the new admin ui library

@trtri2 trtri2 closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants