Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Reliable Detection #1

Open
netvipe opened this issue Dec 23, 2022 · 2 comments
Open

Non-Reliable Detection #1

netvipe opened this issue Dec 23, 2022 · 2 comments

Comments

@netvipe
Copy link

netvipe commented Dec 23, 2022

Hi,

vm-detection is non-reliable, since detecting based on existance of a virtual mac also triggers when e.g. vmware is just installed on the tested endpoint.
mac based detection must be in relation to standard forwarding network interface.
Updated your code and it now detects correctly.
I could provide a simple patch.

@ShellCode33
Copy link
Owner

Hey ! Thanks for your feedback !
PRs are more than welcome, I'd be glad to merge them in if I believe they're worth it

@tufanbarisyildirim
Copy link

@netvipe any update with this? would be happy to see that merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants