Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stamen Toner and Watercolor image tiles #1013

Closed
wants to merge 1 commit into from

Conversation

manugarri
Copy link
Contributor

This simple PR adds the two other versions of static map tiles that Stamen adds.

Basically I modified the StamenTerrain to access the different endpoints for the Toner maps (http://tile.stamen.com/toner/) and Watercolor (http://tile.stamen.com/watercolor/)

@pelson pelson added the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Jan 26, 2018
@manugarri
Copy link
Contributor Author

Become a Contributor with any of the tasks described above. Please note that merging of source code contributions is at the discretion of the Developers and follows an iterative dialogue. We will also need a completed Contributor's Licence Agreement (CLA). Please read the Privacy Policy to understand how we will use any personal data we collect about you.

Hey guys, I just wanted to help with a quick fix, but it seems there is a lot of bureaucracy to collaborate with this project.

@ajdawson
Copy link
Member

Thanks for contributing, we're always happy to have new contributors.

Hey guys, I just wanted to help with a quick fix, but it seems there is a lot of bureaucracy to collaborate with this project

Just a single electronic CLA form to complete: http://scitools.org.uk/documents/cla_form.pdf. Once you fill it in and email to the specified address we can add you to the contributors list and you can submit as many PRs as you like without any more form filling bureaucracy! If you are unsure about CLAs the following is a reasonable overview: http://oss-watch.ac.uk/resources/cla

@manugarri
Copy link
Contributor Author

@ajdawson sent

@manugarri
Copy link
Contributor Author

@pelson I sent the CLA agreement last week :)

@manugarri
Copy link
Contributor Author

@pelson not sure what the next steps are , I sent the signed CLA as instructed by @ajdawson but thew CI is still failling with " CLA doesn't exist for all commits (authors: manugarri) "

@pelson
Copy link
Member

pelson commented Jan 30, 2018

Yep, I'm going through the process of getting the CLA through the door 😄 (not much to it really). Nothing on your side needed. Sorry about the delay.

@manugarri
Copy link
Contributor Author

oh great! Let me know if there is anything else required :)

@QuLogic
Copy link
Member

QuLogic commented Feb 2, 2018

I think you should add either links, or a cross-reference to the StamenTerrain class, for more context.

@manugarri
Copy link
Contributor Author

@QuLogic I did not want to interfere with the current api.

@QuLogic
Copy link
Member

QuLogic commented Feb 3, 2018

I don't understand; I'm talking about the docstrings.

@manugarri
Copy link
Contributor Author

@QuLogic ooh that would make sense. Given how the StamenTerrain docstring only provides a description of the map tiles, can you provide a link to the official Stamen Toner/Watercolor Description? As far as I can tell, these Stamen maps don't have an official description.

@manugarri
Copy link
Contributor Author

@pelson any update on this?

@dopplershift
Copy link
Contributor

I think you need to address the comments by @QuLogic and improve the docstrings. Specifically:

  1. Cross-reference to the StamenTerrain class for the details behind the tiles (":class:`StamenTerrain`" in sphinx)
  2. Link to http://maps.stamen.com/
  3. Add a bit more text describing what they are (i.e. toner is black and white, watercolor is...)

@QuLogic
Copy link
Member

QuLogic commented Oct 16, 2018

Ping @manugarri?

@kaedonkers kaedonkers removed the Blocked: CLA needed See https://scitools.org.uk. Submit the form at: https://scitools.org.uk/cla/v4/form label Nov 5, 2018
@pelson
Copy link
Member

pelson commented Nov 15, 2018

I reviewed this in #1188. Moving the work over to that PR.

@pelson pelson closed this Nov 15, 2018
@manugarri
Copy link
Contributor Author

My apologies @QuLogic , been completely disconnected from this project.

@pelson
Copy link
Member

pelson commented Nov 16, 2018

@manugarri - we've all been there - me more than most! 🤣
Your presence is really welcome anytime - what can be more fun than making maps!? 😉

@QuLogic QuLogic added this to the 0.17 milestone Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants