Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

potential bug - mistaken operator fusion #66

Closed
vpuri3 opened this issue Jun 21, 2022 · 4 comments
Closed

potential bug - mistaken operator fusion #66

vpuri3 opened this issue Jun 21, 2022 · 4 comments

Comments

@vpuri3
Copy link
Member

vpuri3 commented Jun 21, 2022

@ChrisRackauckas lazy sum/compose instead?

SciMLOperators.jl/src/basic.jl

Line 226 in 7f70a6d

@eval Base.$op(x::ScalarOperator, y::ScalarOperator) = $op(x.val, y.val) # TODO - lazy compose instead?

SciMLOperators.jl/src/basic.jl

Line 232 in 7f70a6d

@eval Base.$op(x::ScalarOperator, y::ScalarOperator) = $op(x.val, y.val) # TODO - lazy sum instead?

@ChrisRackauckas
Copy link
Member

yes lazy unless constant. Are the ScalarOperators not always constant? What's the bug?

@vpuri3
Copy link
Member Author

vpuri3 commented Jun 21, 2022

bug = fusion where it should be lazy

@vpuri3
Copy link
Member Author

vpuri3 commented Jun 21, 2022

will fix in next PR

@ChrisRackauckas
Copy link
Member

ahh yes

@vpuri3 vpuri3 mentioned this issue Jun 21, 2022
Merged
5 tasks
@vpuri3 vpuri3 mentioned this issue Jul 1, 2022
Merged
5 tasks
@vpuri3 vpuri3 closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @vpuri3