Update docker container for CI #1393

zaro0508 · 2023-11-28T07:48:53Z

Update circleci docker container with python 3.7 removed and python 3.12 added

depends on Sceptre/sceptre-circleci#19

Update circleci docker container with python 3.7 removed and python 3.12 added depends on Sceptre/sceptre-circleci#19

.flake8

poetry.lock

sceptre/stack.py

pyproject.toml

.circleci/config.yml

iainelder · 2023-12-02T22:53:20Z

If the tests pass, then it looks good to me. I haven't had time to run these locally, but I trust the CI.

The custom image does have all the Python versions we expect.

$ docker run -it --rm sceptreorg/sceptre-circleci:2.1.0 bash -c 'for py in python3.{7,8,9,10,11,12}; do "$py" --version; done'
bash: line 1: python3.7: command not found
Python 3.8.18
Python 3.9.18
Python 3.10.6
Python 3.11.6
Python 3.12.0

iainelder · 2023-12-02T22:54:10Z

I suppose we need to look at #1390 after this to finish adding support for Python 3.12. The main point here is to drop support for Python 3.7.

Adds explicit support for Python 3.12. These are the minimal changes I needed for `pytest` to pass on 3.12 and macOS: * Replaces deprecated [`datetime.datetime.utcnow`](https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow) * Replaces `called_once_with` with `assert_called_once_with`, which now [raises](python/cpython#100690) `AttributeError: 'called_once_with' is not a valid assertion` * Bumps `pytest` due to `DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead` pytest-dev/pytest#10977 * Refreshes the lockfile depends on #1393

Update docker container for CI

cd658af

Update circleci docker container with python 3.7 removed and python 3.12 added depends on Sceptre/sceptre-circleci#19

zaro0508 mentioned this pull request Nov 28, 2023

Update docker container for CI #1392

Closed