fix: potential stack overflow when computing types of lambda parameters #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
lars-reimann
force-pushed
the
type-computer-stack-overflow
branch
from
7e62aae
to
af619cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1173 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 19238 19227 -11
Branches 4114 4119 +5
=========================================
- Hits 19238 19227 -11 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
May 16, 2024
## [0.16.0](v0.15.0...v0.16.0) (2024-05-16) ### Features * eda plot view ([#1161](#1161)) ([a216743](a216743)), closes [#955](#955) [#986](#986) * integrate version 0.25.0 of the `safe-ds` Python library ([#1174](#1174)) ([f357c38](f357c38)) * prefix keywords with `^` to treat them as identifiers ([#1172](#1172)) ([90bd47c](90bd47c)) ### Bug Fixes * potential stack overflow when computing types of lambda parameters ([#1173](#1173)) ([d89511e](d89511e))
|
🎉 This PR is included in version 0.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Due to the interaction between the type computer and the scope provider, the previous approach to prevent endless recursion when computing the type of lambda parameters could fail. This PR provides a more robust implementation to fix this issue.