Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAC2CRC Target argument parsing inefficent #1

Open
hv15 opened this issue Jul 24, 2017 · 1 comment
Open

SAC2CRC Target argument parsing inefficent #1

hv15 opened this issue Jul 24, 2017 · 1 comment
Assignees
Labels

Comments

@hv15
Copy link
Member

hv15 commented Jul 24, 2017

I made a change to the macro in d53c626 which introduced an extra parameter. Sadly, I had assumed that CMake does not check the number of arguments passed to the macro - in principle this is true, however CMake does check that all named arguments are given. As such, the LIBS argument is needed, even if it isn't relevent for the given SAC project, resulting in syntax like:

CREATE_SAC2CRC_TARGET ("modulename" "${DLL_BUILD_DIR}" "${DLL_BUILD_DIR}" "")

Suggested fix for this is to removed the name/required argument and instead check for extra passed arguments using ${ARGN} and parse these seperately - this actually potentially convienet solution to also allow for arbitary values that can be exposed with the project-specific sac2crc file...

@hv15 hv15 self-assigned this Jul 24, 2017
@hv15 hv15 added the bug label Jul 24, 2017
@ashinkarov
Copy link
Collaborator

I wouldn't worry about this too much. As updates in cmake-common do not propagate to sac packages automatically, one can fix this when bumping the version of cmake-common in each package. So I don't think this is a real problem.

Using ${ARGN} is fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants