Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inpainting failing for a particular texture #13

Open
PetrVevoda opened this issue Dec 13, 2022 · 4 comments
Open

Inpainting failing for a particular texture #13

PetrVevoda opened this issue Dec 13, 2022 · 4 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@PetrVevoda
Copy link

Dear authors,

I tried your Colab demo and ran into a problem. When I tried to inpaint the following image:
texture_dark
with this mask:
texture_dark_mask
I got quite a good result:
texture_dark_inpainted

However, if I just made the input image brighter (multiplied pixel values by 2):
texture_bright
the inpainting (with the same mask) failed:
texture_bright_inpainted

I thought it could be some overflow in the image domain, but when I tried to crop the input image a bit (about 10 % on the top and right side):
texture_bright_crop
the inpainting worked again:
texture_bright_crop_inpaint

Could be some overflow in the frequency domain or am I just doing something wrong? Thank you for your response.

@praeclarumjj3
Copy link
Member

praeclarumjj3 commented Dec 14, 2022

Hi @PetrVevoda, thanks for your interest in our work. I did encounter a similar issue while testing myself for some kinds of masks for some reason. I have not had the time to look into the case yet. However, it was solved for me by changing the seed AFAIR. Did you try changing the seed?

The most likely reason seems to be some explosion in the pixel values similar to what you suggested.

@PetrVevoda
Copy link
Author

Yes, I tried several seeds but I only got slightly different noise patterns.

@praeclarumjj3 praeclarumjj3 added the question Further information is requested label Dec 14, 2022
@praeclarumjj3
Copy link
Member

Right, I think it's a mask and image-specific issue. I will look into this when I get the chance. Can you share the image and mask with me?

@PetrVevoda
Copy link
Author

Sure, here they are:
texture_bright
texture_bright_mask

@praeclarumjj3 praeclarumjj3 added the help wanted Extra attention is needed label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants