fix(ui5-dynamic-page): prevent unwanted header toggle from scroll #10007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The snapTitleByScroll function, triggered by scroll events, interfered with user-triggered actions such as onExpandClick and onToggleTitle. This caused the header to snap or close unexpectedly after being manually expanded.
Solution:
An isToggled flag was introduced to temporarily prevent the snapTitleByScroll function from running right after a user-triggered toggle. This ensures that snapTitleByScroll doesn’t fire immediately after a manual action. Once the user toggle is complete, the flag is reset, allowing normal scroll-based snapping to resume without conflict.
Fixes: #9961