Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SF][SelectDialog]: onLoadMore event should not be fired when open the dialog #9959

Open
1 task done
i323808 opened this issue Sep 30, 2024 · 2 comments
Open
1 task done
Labels
bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@i323808
Copy link

i323808 commented Sep 30, 2024

Describe the bug

The onLoadMore event is fired when open the dialog. It should only be fired when user scroll down the list.

Isolated Example

https://stackblitz.com/edit/github-facwbh?file=src%2FApp.tsx

Reproduction steps

  1. open https://stackblitz.com/edit/github-facwbh?file=src%2FApp.tsx
  2. click 'open SelectDialog'
  3. onLoadMore event is fired

Expected Behaviour

The onLoadMore event should only be fired when user scroll down the list.

Screenshots or Videos

No response

UI5 Web Components for React Version

2.2.0

UI5 Web Components Version

2.1.1

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@i323808 i323808 added the bug This issue is a bug in the code label Sep 30, 2024
@Lukas742
Copy link
Collaborator

Hi @i323808

the onLoadMore event of the List is fired on initial mount, only if there are no list items rendered. Since this behavior is not described in the documentation, I'm assuming this is a bug and will therefore forward this issue to the ui5-webcomponents repo.


Hi Colleagues,

the load-more event is triggered on initial mount of the ui5-list, if it initially doesn't have any children. Here you can find an example using only JS and HTML without React or our wrapper: https://stackblitz.com/edit/github-cutgnx-xqhn5c?file=index.html,main.js,package.json

Steps to reproduce:

  1. Go to the StackBlitz example
  2. Open the dialog
  3. See that the load-more event was fired.

@Lukas742 Lukas742 transferred this issue from SAP/ui5-webcomponents-react Sep 30, 2024
@LidiyaGeorgieva
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p,

Please have a look.
This is either a bug or documentation should be enhanced.

Best regards,
Lidiya

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Status: 🆕 New
Development

No branches or pull requests

3 participants