refactor(ui5-shellbar): Improve control behaviour #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapTo0
changed the title
ilhan007
reviewed
Feb 19, 2019
| document.getElementById("shellbar").addEventListener("profilePress", event => { | ||
| console.log("profile"); | ||
| shellbar.addEventListener("notificationsPress", function(event) { | ||
| window["press-input"].value = "Notifications" |
There was a problem hiding this comment.
check if the sample works on ie and edge just in case as I have feeling that the id of an element is not assigned to the window object in one of these browsers, just check if everything is fine.
ilhan007
approved these changes
Feb 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.