-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui5-textarea): implement input event #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need to call bind() for event handlers this way, please rework it by just passing the functions in the template (as we now give lit-html the event context)
packages/main/src/TextArea.js
Outdated
const nativeTextarea = this.getInputDomRef(); | ||
|
||
/* skip calling change event when an textarea with a placeholder is focused on IE | ||
- value of the host and the internal textarea should be differnt in case of actual textarea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the comments:
-
typo in "differnt" -> different
-
in case of actual "textarea"
(I guess this should be: in case of actual input/typing) -
"textarea" is called when a key is pressed
(I guess this should be: the "input" event is called when a key is pressed)
} | ||
|
||
this.value = nativeTextarea.value; | ||
this.fireEvent("input", {}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add "value-change" to make "origami" work?
No description provided.