Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide named exports for some base modules #347

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 19, 2019

  • UI5Element is now default export of webcomponents-base
  • Theming features exported in "@ui5/webcomponents-base/Theming"

- UI5Element is now default export of webcomponents-base
- Theming features exported in - "@ui5/webcomponents-base/Theming"
@MapTo0
Copy link
Member Author

MapTo0 commented Apr 19, 2019

Example:

import "@ui5/webcomponents/dist/Select";

import "@ui5/webcomponents/dist/ThemePropertiesProvider";
import { setTheme, addCustomCSS } from "@ui5/webcomponents-base/Theming";

setTheme("sap_belize_hcb");
addCustomCSS("ui5-select", "sap_fiori_3", "* { color: red }");

@MapTo0 MapTo0 requested a review from pskelin April 19, 2019 12:54
pskelin
pskelin previously approved these changes Apr 19, 2019
packages/base/Theming.js Outdated Show resolved Hide resolved
@MapTo0
Copy link
Member Author

MapTo0 commented Apr 19, 2019

#328

@MapTo0 MapTo0 merged commit 2e2439a into master Apr 20, 2019
@MapTo0 MapTo0 deleted the re-export-base branch April 20, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants