refactor(ui5-tabcontainer): refactor the component #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-bobev
force-pushed
the
refactor-tabcontainer
branch
from
1a388f8
to
6095402
Compare
BREAKING CHANGE: 'selectedIndex' property is removed. Instead use 'selected' property of the Tab BREAKING CHANGE: 'headerMode' property is removed. All Tabs by Fiori guidelines are rendered in inline mode BREAKING CHANGE: 'headerBackgroundDesign' property is removed BREAKING CHANGE: 'backgroundDesign' property is removed BREAKING CHANGE: 'content' property is removed. Instead if you want to use the TabContainer as a filter just use it with 'collapsed' set to true and 'fixed' set to true BREAKING CHANGE: 'TabContainerDensityMode' is deleted. To set different size modes use ?sap-ui-comp actSize=true BREAKING CHANGE: Tab's 'design' property is removed BREAKING CHANGE: Tab's 'count' property is removed. Instead use the additional-text property
adrian-bobev
force-pushed
the
refactor-tabcontainer
branch
from
6095402
to
ac5230c
Compare
adrian-bobev
force-pushed
the
refactor-tabcontainer
branch
from
23eb9ac
to
c082004
Compare
MapTo0
requested changes
Apr 10, 2019
There was a problem hiding this comment.
-
we should also mention that there is not default selected tab anymore. All apps should define a selected tab by property (used to be: if no selected - select the first one). This is a breaking change.
-
text color of text and additional-text
-
make inline-block and 100% width by default (root)
-
remove margin of additional-text with icon only
-
set initial tab index
|
Lets fix the last point as a new issue, since it is reproducible even before the refactoring |
adrian-bobev
force-pushed
the
refactor-tabcontainer
branch
from
38cdc35
to
af01afc
Compare
adrian-bobev
force-pushed
the
refactor-tabcontainer
branch
from
31142b0
to
f1dfe63
Compare
MapTo0
approved these changes
Apr 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #313
BREAKING CHANGE: 'selectedIndex' property is removed. Instead use 'selected' property of the Tab
BREAKING CHANGE: 'headerMode' property is removed. All Tabs by Fiori guidelines are rendered in
inline mode
BREAKING CHANGE: 'headerBackgroundDesign' property is removed
BREAKING CHANGE: 'backgroundDesign' property is removed
BREAKING CHANGE: 'content' property is removed. Instead if you want to use the TabContainer as
a filter just use it with 'collapsed' set to true and 'fixed' set to true
BREAKING CHANGE: 'TabContainerDensityMode' is deleted. To set different size modes use ?sap-ui-compactSize=true
BREAKING CHANGE: Tab's 'design' property is removed
BREAKING CHANGE: Tab's 'count' property is removed. Instead use the additional-text property