Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-shellbar): rename press handlers param #300

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

MapTo0
Copy link
Member

@MapTo0 MapTo0 commented Apr 4, 2019

BREAKING CHANGE: press handlers used to have param "iconRef". As not always
an Icon is pressed (e.g. title is not an icon) - the parameter is renamed to targetRef.

Fixes: #297

BREAKING CHANGE: press handlers used to have param "iconRef". As not always
an Icon is pressed (e.g. title is not an icon) - the parameter is renamed to targetRef.

Fixes: #297
@MapTo0 MapTo0 requested a review from fifoosid April 4, 2019 10:55
@MapTo0 MapTo0 merged commit 5d1c920 into master Apr 4, 2019
@MapTo0 MapTo0 deleted the shellbar-event-params-rename branch April 4, 2019 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants