Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui5-combobox): аdd two-column layout support #2503

Merged
merged 5 commits into from
Nov 22, 2020
Merged

feat(ui5-combobox): аdd two-column layout support #2503

merged 5 commits into from
Nov 22, 2020

Conversation

ndeshev
Copy link
Contributor

@ndeshev ndeshev commented Nov 20, 2020 •
edited
Loading

This change adds support for two-column layout in the ComboBox web component so that the apps can display additional information for the selection options, such as currencies, country abbreviations, or system abbreviations.

Overview

New property additionalText is added to the ComboBoxItem.js

Usage

<ui5-combobox>
     <ui5-cb-item text="Bulgaria" additional-text="BG"></ui5-cb-item>
</ui5-combobox>

Feature request: #2450

Capture2

@ndeshev
Add additionalText property to ComboBoxItem
5649c52 
Adds additional text property to the ComboBox which displays additional
info for the list item.
@ndeshev ndeshev changed the title Add additionalText property to ComboBoxItem feat(ui5-combobox): Add two-column layout support Nov 20, 2020
@ilhan007 ilhan007 changed the title feat(ui5-combobox): Add two-column layout support feat(ui5-combobox): аdd two-column layout support Nov 21, 2020
@ilhan007 ilhan007 merged commit 679362d into SAP:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilhan007 ilhan007 ilhan007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndeshev @ilhan007