fix(ui5-timepicker): fix JS Error, improve user XP and sample #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilhan007
changed the title
vladitasev
approved these changes
Mar 26, 2020
tsanislavgatev
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when imported standalone, JS error is thrown - Gregorian calendar was missing.
allow user to set empty value or removing the current time with "BACKSPACE", instead of always setting the current time.
placeholder exists in the code, but never forwarded to the Input and not documented as part of the public API
show time format as placeholder, when no value
fix code snippets alignment in playground
FIXES: #1357