Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-input) implement valueStateMessage when no suggestions #1297

Merged
merged 12 commits into from
Mar 25, 2020

Conversation

ivoplashkov
Copy link
Member

Implement valueStateMessage when the input has no suggestions.

packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
Copy link
Member

@ilhan007 ilhan007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall good, few comments and please add a test.

packages/main/src/Input.js Outdated Show resolved Hide resolved
packages/main/src/Input.js Outdated Show resolved Hide resolved
@ilhan007 ilhan007 closed this Mar 24, 2020
@ilhan007 ilhan007 reopened this Mar 24, 2020
@ilhan007 ilhan007 merged commit 538a79a into SAP:master Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants