refactor(ui5-popover): rename hideArrow property to noArrow (#509)

BREAKING CHANGE: hideArrow property is renamed to noArrow
SAP · Jun 18, 2019 · efff863 · efff863
1 parent a90c5f5
commit efff863
Show file tree

Hide file tree

Showing 9 changed files with 12 additions and 12 deletions.
diff --git a/packages/main/src/DatePicker.hbs b/packages/main/src/DatePicker.hbs
@@ -31,7 +31,7 @@
 			allow-target-overlap="{{_popover.allowTargetOverlap}}"
 			placement-type="{{_popover.placementType}}"
 			no-header="{{_popover.noHeader}}"
-			hide-arrow="{{_popover.hideArrow}}"
+			no-arrow="{{_popover.noArrow}}"
 			horizontal-align="{{_popover.horizontalAlign}}"
 			stay-open-on-scroll="{{_popover.stayOpenOnScroll}}"
 			@ui5-afterClose="{{_popover.afterClose}}"

diff --git a/packages/main/src/DatePicker.js b/packages/main/src/DatePicker.js
@@ -254,7 +254,7 @@ class DatePicker extends UI5Element {
 			placementType: PopoverPlacementType.Bottom,
 			horizontalAlign: PopoverHorizontalAlign.Left,
 			noHeader: true,
-			hideArrow: true,
+			noArrow: true,
 			allowTargetOverlap: true,
 			stayOpenOnScroll: true,
 			afterClose: () => {

diff --git a/packages/main/src/Input.hbs b/packages/main/src/Input.hbs
@@ -31,7 +31,7 @@
 			<ui5-popover
 				placement-type="Bottom"
 				no-header="true"
-				hide-arrow="true"
+				no-arrow="true"
 				horizontal-align="Stretch"
 				initial-focus="{{_id}}-inner">
 					<ui5-list separators="Inner">

diff --git a/packages/main/src/MultiComboBox.hbs b/packages/main/src/MultiComboBox.hbs
@@ -37,7 +37,7 @@
 		class="ui5-multi-combobox-selected-items--popover"
 		horizontal-align="Stretch"
 		no-header
-		?hide-arrow={{editable}}
+		?no-arrow={{editable}}
 		placement-type="Bottom">
 		<ui5-list separators="None" mode="{{selectedItemsListMode}}"
 			@ui5-selectionChange={{_listSelectionChange}}>
@@ -50,8 +50,8 @@
 	</ui5-popover>
 
 	<ui5-popover class="ui5-multi-combobox-all-items--popover"
+		no-arrow
 		no-header
-		hide-arrow
 		horizontal-align="Stretch"
 		initial-focus="ui5-multi-combobox--input"
 		horizontal-align="Left"

diff --git a/packages/main/src/Popover.js b/packages/main/src/Popover.js
@@ -81,7 +81,7 @@ const metadata = {
 		 * @defaultvalue false
 		 * @public
 		 */
-		hideArrow: {
+		noArrow: {
 			type: Boolean,
 		},
 
@@ -417,7 +417,7 @@ class Popover extends Popup {
 		this._width = width;
 		this._height = height;
 
-		const arrowOffset = this.hideArrow ? 0 : arrowSize;
+		const arrowOffset = this.noArrow ? 0 : arrowSize;
 
 		// calc popover positions
 		switch (placementType) {
@@ -618,7 +618,7 @@ class Popover extends Popup {
 			},
 			arrow: {
 				sapMPopoverArr: true,
-				sapMPopoverArrHidden: this.hideArrow,
+				sapMPopoverArrHidden: this.noArrow,
 				sapMPopoverArrLeft: placementType === PopoverPlacementType.Right,
 				sapMPopoverArrRight: placementType === PopoverPlacementType.Left,
 				sapMPopoverArrUp: placementType === PopoverPlacementType.Bottom,

diff --git a/packages/main/src/Select.hbs b/packages/main/src/Select.hbs
@@ -13,7 +13,7 @@
 		<ui5-popover
 			placement-type="Bottom"
 			no-header="true"
-			hide-arrow="true"
+			no-arrow="true"
 			horizontal-align="Stretch">
 				<ui5-list separators="None">
 					<slot></slot>

diff --git a/packages/main/src/ShellBar.hbs b/packages/main/src/ShellBar.hbs
@@ -75,7 +75,7 @@
 		</div>
 	</div>
 
-	<ui5-popover class="sapWCShellBarOverflowPopover" placement-type="Bottom" horizontal-align="{{popoverHorizontalAlign}}" no-header hide-arrow>
+	<ui5-popover class="sapWCShellBarOverflowPopover" placement-type="Bottom" horizontal-align="{{popoverHorizontalAlign}}" no-header no-arrow>
 		<ui5-list separators="None" @ui5-itemPress="{{_actionList.itemPress}}">
 			{{#each _hiddenIcons}}
 				<ui5-li

diff --git a/packages/main/src/TabContainer.hbs b/packages/main/src/TabContainer.hbs
@@ -72,7 +72,7 @@
 	<!-- overflow menu -->
 	<ui5-popover
 		id="{{_id}}-overflowMenu"
-		hide-arrow
+		no-arrow
 		no-header
 		placement-type="Bottom"
 		horizontal-align="Right">

diff --git a/packages/main/test/sap/ui/webcomponents/main/pages/Popups.html b/packages/main/test/sap/ui/webcomponents/main/pages/Popups.html
@@ -66,7 +66,7 @@
 		<content id="popover"></content>
 	</div>
 
-	<ui5-popover placement-type="Bottom" horizontal-align="Stretch" hide-arrow no-header initial-focus="input1" class="wcPopoverWithList">
+	<ui5-popover placement-type="Bottom" horizontal-align="Stretch" no-arrow no-header initial-focus="input1" class="wcPopoverWithList">
 		<ui5-list id="myList" inset separators="Inner" mode="MultiSelect" footer-text="Copyright" no-data-text="No data">
 			<!-- Header -->
 			<div style="display: flex; align-items: center;" slot="header">