fix(ui5-icon): Icon now has a correct role (#1652)

SAP · May 20, 2020 · d9933bd · d9933bd
1 parent 61ce284
commit d9933bd
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/packages/main/src/CalendarHeader.hbs b/packages/main/src/CalendarHeader.hbs
@@ -51,5 +51,5 @@
 			name="{{_btnNext.icon}}"
 		>
 		</ui5-icon>
-
+    </div>
 </div>
diff --git a/packages/main/src/Icon.hbs b/packages/main/src/Icon.hbs
@@ -3,7 +3,7 @@
 	tabindex="{{tabIndex}}"
 	dir="{{dir}}"
 	viewBox="0 0 512 512"
-	role="img"
+	role="{{role}}"
 	focusable="false"
 	preserveAspectRatio="xMidYMid meet"
 	aria-label="{{accessibleNameText}}"

diff --git a/packages/main/src/Icon.js b/packages/main/src/Icon.js
@@ -198,6 +198,14 @@ class Icon extends UI5Element {
 		return this.interactive ? "0" : "-1";
 	}
 
+	get role() {
+		if (this.interactive) {
+			return "button";
+		}
+
+		return this.accessibleNameText ? "img" : "presentation";
+	}
+
 	static createGlobalStyle() {
 		if (!window.ShadyDOM) {
 			return;