From c55bcdc8b4d05330d1c731e4b7ef005bdd2ecea6 Mon Sep 17 00:00:00 2001
From: ilhan orhan <ilhan.myumyun@sap.com>
Date: Thu, 23 Apr 2020 16:06:52 +0300
Subject: [PATCH] feat(ui5-carousel): add navigate event (#1454)

The event is fired whenever the selectedIndex changes due to user interaction - when the user clicks on the navigation arrows or while resizing, based on the "items-per-page-s/m/l" properties.

Fixes: https://github.com/SAP/ui5-webcomponents/issues/1449
---
 packages/main/src/Carousel.hbs            |  4 +++
 packages/main/src/Carousel.js             | 36 +++++++++++++++++++--
 packages/main/test/pages/Carousel.html    | 21 ++++++++++++
 packages/main/test/specs/Carousel.spec.js | 39 +++++++++++++++++++++++
 4 files changed, 98 insertions(+), 2 deletions(-)

diff --git a/packages/main/src/Carousel.hbs b/packages/main/src/Carousel.hbs
index 63e919d60d19..593afa9d0b57 100644
--- a/packages/main/src/Carousel.hbs
+++ b/packages/main/src/Carousel.hbs
@@ -24,6 +24,7 @@
         {{#if arrows.content}}
             <div class="ui5-carousel-navigation-arrows">
                 <ui5-button
+                    arrow-back
                     class="ui5-carousel-navigation-button {{classes.navPrevButton}}"
                     icon="slim-arrow-left"
                     tabindex="-1"
@@ -31,6 +32,7 @@
                     @keydown={{_onbuttonkeydown}}
                 ></ui5-button>
                 <ui5-button
+                    arrow-forward
                     class="ui5-carousel-navigation-button {{classes.navNextButton}}"
                     icon="slim-arrow-right"
                     tabindex="-1"
@@ -44,6 +46,7 @@
             <div class="{{classes.navigation}}">
                 {{#if arrows.navigation}}
                 <ui5-button
+                    arrow-back
                     class="ui5-carousel-navigation-button {{classes.navPrevButton}}"
                     icon="slim-arrow-left"
                     tabindex="-1"
@@ -69,6 +72,7 @@
 
                 {{#if arrows.navigation}}
                     <ui5-button
+                        arrow-forward
                         class="ui5-carousel-navigation-button {{classes.navNextButton}}"
                         icon="slim-arrow-right"
                         tabindex="-1"
diff --git a/packages/main/src/Carousel.js b/packages/main/src/Carousel.js
index 45c1cf94049c..0f04050921fa 100644
--- a/packages/main/src/Carousel.js
+++ b/packages/main/src/Carousel.js
@@ -90,7 +90,7 @@ const metadata = {
 		},
 
 		/**
-		 * Defines the index of the initially selected page.
+		 * Defines the index of the initially selected item.
 		 * @type {Integer}
 		 * @defaultvalue 0
 		 * @public
@@ -152,7 +152,22 @@ const metadata = {
 		},
 	},
 	events: /** @lends sap.ui.webcomponents.main.Carousel.prototype */ {
-		//
+
+		/**
+		 * Fired whenever the <code>selectedIndex</code> changes due to user interaction,
+		 * when the user clicks on the navigation arrows or while resizing,
+		 * based on the <code>items-per-page-l</code>, <code>items-per-page-m</code> and <code>items-per-page-s</code> properties.
+		 *
+		 * @event
+		 * @param {Integer} selectedIndex the current <code>selectedIndex</code>.
+		 * @public
+		 * @since 1.0.0-rc.7
+		 */
+		navigate: {
+			detail: {
+				selectedIndex: { type: Integer },
+			},
+		},
 	},
 };
 
@@ -263,6 +278,7 @@ class Carousel extends UI5Element {
 
 		if (this.selectedIndex > this.pagesCount - 1) {
 			this.selectedIndex = this.pagesCount - 1;
+			this.fireEvent("navigate", { selectedIndex: this.selectedIndex });
 		}
 	}
 
@@ -291,6 +307,10 @@ class Carousel extends UI5Element {
 	}
 
 	navigateLeft() {
+		this._resizing = false;
+
+		const peviousSelectedIndex = this.selectedIndex;
+
 		if (this.selectedIndex - 1 < 0) {
 			if (this.cyclic) {
 				this.selectedIndex = this.pagesCount - 1;
@@ -298,9 +318,17 @@ class Carousel extends UI5Element {
 		} else {
 			--this.selectedIndex;
 		}
+
+		if (peviousSelectedIndex !== this.selectedIndex) {
+			this.fireEvent("navigate", { selectedIndex: this.selectedIndex });
+		}
 	}
 
 	navigateRight() {
+		this._resizing = false;
+
+		const peviousSelectedIndex = this.selectedIndex;
+
 		if (this.selectedIndex + 1 > this.pagesCount - 1) {
 			if (this.cyclic) {
 				this.selectedIndex = 0;
@@ -308,6 +336,10 @@ class Carousel extends UI5Element {
 		} else {
 			++this.selectedIndex;
 		}
+
+		if (peviousSelectedIndex !== this.selectedIndex) {
+			this.fireEvent("navigate", { selectedIndex: this.selectedIndex });
+		}
 	}
 
 	/**
diff --git a/packages/main/test/pages/Carousel.html b/packages/main/test/pages/Carousel.html
index c32780cdf2ff..693b3ff3a13b 100644
--- a/packages/main/test/pages/Carousel.html
+++ b/packages/main/test/pages/Carousel.html
@@ -484,5 +484,26 @@
 	<ui5-button>Button 9</ui5-button>
 </ui5-carousel>
 
+<ui5-carousel id="carousel8" items-per-page-m="4" items-per-page-l="4">
+	<ui5-button>Button 1</ui5-button>
+	<ui5-button>Button 2</ui5-button>
+	<ui5-button>Button 3</ui5-button>
+	<ui5-button>Button 4</ui5-button>
+	<ui5-button>Button 5</ui5-button>
+	<ui5-button>Button 6</ui5-button>
+	<ui5-button>Button 7</ui5-button>
+	<ui5-button>Button 8</ui5-button>
+</ui5-carousel>
+<ui5-input id="result"></ui5-input>
+<ui5-input id="resultCounter"></ui5-input>
+
 </body>
+
+<script>
+	var counter = 0;
+	carousel8.addEventListener("ui5-navigate", function(event){
+		result.value = event.detail.selectedIndex;
+		resultCounter.value = ++counter;
+	});
+</script>
 </html>
diff --git a/packages/main/test/specs/Carousel.spec.js b/packages/main/test/specs/Carousel.spec.js
index 16a9e0610644..160a1678af15 100644
--- a/packages/main/test/specs/Carousel.spec.js
+++ b/packages/main/test/specs/Carousel.spec.js
@@ -110,4 +110,43 @@ describe("Carousel general interaction", () => {
 		assert.strictEqual(selectedIndex, NORMALIZED_INDEX,
 			"Although '15' is set, the actual selectedIndex is changed to 0.");
 	});
+
+	it("Event navigate fired when pressing navigation arrows", () => {
+		const carousel = browser.$("#carousel8");
+		const selectedIndex = browser.$("#result");
+		const eventCounter = browser.$("#resultCounter");
+		const navigationArrowForward = carousel.shadow$("ui5-button[arrow-forward]");
+		const navigationArrowsBack = carousel.shadow$("ui5-button[arrow-back]");
+
+		// using the navigtion arrows
+		navigationArrowForward.click(); // forward
+		assert.strictEqual(selectedIndex.getProperty("value"), "1", "The selectedIndex is correct.");
+		assert.strictEqual(eventCounter.getProperty("value"), "1", "The navigate event is fired.");
+
+		navigationArrowForward.click(); // forward
+		assert.strictEqual(selectedIndex.getProperty("value"), "2", "The selectedIndex is correct.");
+		assert.strictEqual(eventCounter.getProperty("value"), "2", "The navigate event is fired.");
+
+		navigationArrowsBack.click(); // back
+		assert.strictEqual(selectedIndex.getProperty("value"), "1", "The selectedIndex is correct");
+		assert.strictEqual(eventCounter.getProperty("value"), "3", "The navigate event is fired.");
+
+		navigationArrowsBack.click(); // back
+		assert.strictEqual(selectedIndex.getProperty("value"), "0", "The selectedIndex is correct.");
+		assert.strictEqual(eventCounter.getProperty("value"), "4", "The navigate event is fired.");
+
+		// using the keyboard navigation
+		carousel.click();
+		carousel.keys("ArrowRight");
+		assert.strictEqual(selectedIndex.getProperty("value"), "1", "The selectedIndex is correct.");
+		assert.strictEqual(eventCounter.getProperty("value"), "5", "The navigate event is fired.");
+
+		carousel.keys("ArrowLeft");
+		assert.strictEqual(selectedIndex.getProperty("value"), "0", "The selectedIndex is correct.");
+		assert.strictEqual(eventCounter.getProperty("value"), "6", "The navigate event is fired.");
+
+		carousel.keys("ArrowLeft");
+		assert.strictEqual(selectedIndex.getProperty("value"), "0", "The selectedIndex is correct.");
+		assert.strictEqual(eventCounter.getProperty("value"), "6", "The navigate event is not fired as no previous item.");
+	});
 });