From 44e631aaf0ca630f2ac9507f255b1a544832c835 Mon Sep 17 00:00:00 2001 From: Vladislav Tasev Date: Tue, 21 Jan 2020 06:07:42 +0200 Subject: [PATCH] fix: Dialog does not break when there is no header text (#1146) --- packages/main/src/Popup.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/main/src/Popup.js b/packages/main/src/Popup.js index 4b6b2840a227..210b9b0e4826 100644 --- a/packages/main/src/Popup.js +++ b/packages/main/src/Popup.js @@ -445,7 +445,8 @@ class Popup extends UI5Element { } get hasHeader() { - return !!(this.headerText.length || this.header.length); + const hasHeaderText = this.headerText && this.headerText.length; + return !!(hasHeaderText || this.header.length); } get hasFooter() {