fix(ui5-dialog): no longer gets clipped in short screen height in IE (#…

…2429) Fixes: #2243
SAP · Nov 4, 2020 · 03c8447 · 03c8447
1 parent efb0d8e
commit 03c8447
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/main/src/Dialog.js b/packages/main/src/Dialog.js
@@ -182,6 +182,10 @@ class Dialog extends Popup {
 		return true;
 	}
 
+	get _displayProp() {
+		return "flex";
+	}
+
 	get classes() {
 		return {
 			root: {

diff --git a/packages/main/src/Popup.js b/packages/main/src/Popup.js
@@ -204,6 +204,10 @@ class Popup extends UI5Element {
 		return staticAreaStyles;
 	}
 
+	get _displayProp() {
+		return "block";
+	}
+
 	/**
 	 * Prevents the user from interacting with the content under the block layer
 	 */
@@ -393,11 +397,11 @@ class Popup extends UI5Element {
 	}
 
 	/**
-	 * Sets "block" display to the popup
+	 * Sets "block" display to the popup. The property can be overriden by derivatives of Popup.
 	 * @protected
 	 */
 	show() {
-		this.style.display = "block";
+		this.style.display = this._displayProp;
 	}
 
 
@@ -417,7 +421,7 @@ class Popup extends UI5Element {
 	}
 
 	/**
-	 * Implement this getter with relevant logic regarding the modality of the popup (f.e. based on a public property)
+	 * Implement this getter with relevant logic regarding the modality of the popup (e.g. based on a public property)
 	 *
 	 * @protected
 	 * @abstract