Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isWithinShow not correctly handling end times after midnight #131

Closed
RocketMan opened this issue Jan 31, 2020 · 0 comments
Closed

isWithinShow not correctly handling end times after midnight #131

RocketMan opened this issue Jan 31, 2020 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@RocketMan
Copy link
Owner

isWithinShow is currently special casing a show end time of '0000' (midnight) but does not handle end times after midnight; for example, 2300-0200. Such a showtime will cause isWithinShow to indicate times are not within the show when they really are.

The correct solution is to test if the end time is less than the start time; if so, then the end date needs to be increased by 1, because it means the show ends the next day. Thus a show on 2020-01-20 from 2300-0200 will have end time 2020-01-21 0200.

@RocketMan RocketMan added the bug Something isn't working label Jan 31, 2020
@RocketMan RocketMan added this to the v2.7.0 milestone Jan 31, 2020
@RocketMan RocketMan self-assigned this Jan 31, 2020
@RocketMan RocketMan mentioned this issue Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant