Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify variables structures for predictions functionality #248

Merged
merged 76 commits into from
Sep 19, 2023
Merged

Modify variables structures for predictions functionality #248

merged 76 commits into from
Sep 19, 2023

Conversation

albertpod
Copy link
Member

This PR aims at bringing the prediction functionality into RxInfer.jl.
Linked with PR#51

albertpod and others added 30 commits October 17, 2022 12:52
@albertpod
Add MAR node
da44b05
@albertpod
Add rules prototypes
ef8e17e
@albertpod
Add rules for MAR
35aba35
@albertpod
Update MAR
3462700
@albertpod
Merge branch 'master' into mar
b160302
@albertpod
Merge branch 'master' into mar
24cfeaf
@albertpod
Update rules
91179d1
@albertpod
Update rules
6795aff
@albertpod
WIP: Update mask MAR function
bd7be22
@albertpod
Bug fix
86a24e4
@albertpod
Update rules
dcb5bd5
@albertpod
Update rules
adc58ad
@bvdmitri
project: add BlockArrays dependency
ee8b471
@bvdmitri
Merge branch 'mar' of github.com:biaslab/ReactiveMP.jl into mar
a41b0d9
@bvdmitri
fix constructor
4d3e221
@albertpod
Update rules
09140d1
@albertpod
Merge branch 'mar' of https://github.com/biaslab/ReactiveMP.jl into mar
9e15486
@albertpod
Update FE
78c5216
@ismailsenoz
Merge branch 'master' into mar
a723fcd
@albertpod
Update rule
67d47cc
@albertpod
Merge branch 'mar' of https://github.com/biaslab/ReactiveMP.jl into mar
96731d0
@albertpod
Update MAR rules
f2fd4d5
@albertpod
Update rules
5eab7be
@albertpod
WIP: Update marginals & lambda
395ea37
@albertpod
Fix bug
2725813
@albertpod
Fix backward rule
cfc4243
@albertpod
Update rules
7a91826
@albertpod
Fix FE
d5248e0
@albertpod
Clean up
01f59f1
@albertpod
Update rules
a839f3d
@albertpod albertpod changed the title [DO NOT MERGE] Modify variables structures for predictions functionality Modify variables structures for predictions functionality Sep 12, 2023
@albertpod
Copy link
Member Author

The branch hasn't been touched for a while, so I am doing a short summary about updates:

  • Removed several dispatch rules for resolve_factorisation with unspecified constraints and stochastic nodes with 2 and 3 inputs.
  • Added new dispatch rules for resolve_factorisation with unspecified constraints and stochastic nodes with 2 and 3 inputs.
  • Modified the logic for determining the marginal value.
  • Modified the logic for determining the result and addons values.

@albertpod albertpod marked this pull request as ready for review September 12, 2023 15:39
bvdmitri
bvdmitri reviewed Sep 18, 2023
View reviewed changes
src/variables/data.jl Outdated Show resolved Hide resolved
src/variables/data.jl Outdated Show resolved Hide resolved
@albertpod @bvdmitri
Update src/variables/data.jl
0c94a12 
Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>
@albertpod
Copy link
Member Author

seems good
ping @bvdmitri

@bvdmitri bvdmitri merged commit dff2b15 into master Sep 19, 2023
5 of 7 checks passed
@bvdmitri bvdmitri deleted the dev-predict branch September 19, 2023 07:37
@bvdmitri bvdmitri mentioned this pull request Oct 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvdmitri bvdmitri bvdmitri left review comments

@bartvanerp bartvanerp Awaiting requested review from bartvanerp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@albertpod @codecov-commenter @bvdmitri @ismailsenoz