Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gsdtool shouldn't panic when encountering PrmText that violates value constraint #16

Open
Rahix opened this issue Apr 21, 2024 · 0 comments
Open

gsdtool shouldn't panic when encountering PrmText that violates value constraint #16

Rahix opened this issue Apr 21, 2024 · 0 comments
Labels
bug Something isn't working gsdtool GSD CLI Utility

Comments

@Rahix
Copy link
Owner

Rahix commented Apr 21, 2024

It seems rather common that PrmText values actually do not fit into the limits imposed by a ExtUserPrmData definition.

Right now, gsdtool simply panics in this situation with a message like:

thread 'main' panicked at gsd-parser/src/lib.rs:214:17:
value 3 not in range 7..=7

Instead we should probably simply issue a warning and opt to continue anyway...

Alternatively, we might want to filter the PrmText for values that are actually allowed. Not sure how others are handling this?
@Rahix Rahix added bug Something isn't working gsdtool GSD CLI Utility labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working gsdtool GSD CLI Utility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rahix