Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generator support in bm25 #2479

Merged
merged 2 commits into from
May 30, 2019
Merged

generator support in bm25 #2479

merged 2 commits into from
May 30, 2019

Conversation

saraswatmks
Copy link
Contributor

@saraswatmks saraswatmks commented May 6, 2019 •
edited by piskvorky
Loading

Fixes #2434.

This PR does the following:

  1. Make bm25 accept generators as inputs.

mpenkov
mpenkov approved these changes May 7, 2019
View reviewed changes
Copy link
Collaborator

@mpenkov mpenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@mpenkov mpenkov added the bugfix label May 7, 2019
@saraswatmks
Copy link
Contributor Author

saraswatmks commented May 21, 2019 •
edited
Loading

Looks good to me

@mpenkov I discovered this is approved but not merged. Anything else to be done ?

@mpenkov mpenkov merged commit 7484627 into piskvorky:develop May 30, 2019
@mpenkov
Copy link
Collaborator

mpenkov commented May 30, 2019

No, that's it. I've merged your changes. Thank you for reminding me about this PR, and for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpenkov mpenkov mpenkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BM25 does not support generator as corpus
2 participants
@saraswatmks @mpenkov