Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flake8 warnings W605, W504 #2256

Merged
merged 4 commits into from
Dec 11, 2018
Merged

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Nov 2, 2018

Since recent release of flake8 (v3.6.0, 24.10.18) all PR-s have not been building due to new warnings W605 W504 (pycodestyle - dependence of flake8, version 2.4.0).

Now, by edited pep 8 you should break the line before binary operator, not after. And avoid slash with followed non-special character like 'i', '*' or others in non-raw string.

Also, here we pin flake8-rst == 0.4.3 until bug with E402 ("glue" rst) will be fixed.

@horpto horpto changed the title Fix flake8 warnings W605 and build Fix flake8 warnings W605 Nov 6, 2018
@horpto horpto changed the title Fix flake8 warnings W605 Fix flake8 warnings W605, ignore W504 Nov 6, 2018
@piskvorky
Copy link
Owner

piskvorky commented Nov 9, 2018

Can you fill in the PR description please?

The PR name and the codes are too cryptic: What is this PR for, why (motivation), what was the main approach for its fix(es)?

@horpto horpto changed the title Fix flake8 warnings W605, ignore W504 Fix flake8 warnings W605, W504 Nov 11, 2018
@menshikh-iv menshikh-iv merged commit 30528a5 into piskvorky:develop Dec 11, 2018
@menshikh-iv
Copy link
Contributor

Nice, thank you @horpto 👍

@horpto horpto deleted the gensim-build branch January 10, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants