Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed pyemd import error, pythonic equality and typo #2228 #2240

Merged
merged 5 commits into from
Jan 9, 2019
Merged

Fixed pyemd import error, pythonic equality and typo #2228 #2240

merged 5 commits into from
Jan 9, 2019

Conversation

ramprakash-94
Copy link
Contributor

  1. Explicitly imported pyemd inside wmdistance function
  2. Updated document length check to a pythonic way
  3. Fixed typo mentioned in the issue

piskvorky
piskvorky requested changes Oct 23, 2018
View reviewed changes
gensim/models/keyedvectors.py Outdated Show resolved Hide resolved
@ramprakash-94
Copy link
Contributor Author

I think it should work now!

@ramprakash-94
Copy link
Contributor Author

@piskvorky Can you please take a look at this now? Thanks.

@menshikh-iv menshikh-iv mentioned this pull request Jan 9, 2019
Closed
@menshikh-iv
Copy link
Contributor

Thanks @ramprakash-94, congratz with the first contribution 🥇

@menshikh-iv menshikh-iv merged commit 6af20b6 into piskvorky:develop Jan 9, 2019
@menshikh-iv menshikh-iv mentioned this pull request Jan 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramprakash-94 @menshikh-iv @piskvorky