Added better error message for unsupported fastText supervised models #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ElSaico, nice work, but model is VERY large, please create very small model (<=1MB) and add it for test. |
|
@menshikh-iv just shrank it down to a model 1/10 of the size - and |
|
Congratz with your first contribution @ElSaico 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1498.
Also adds a new corpus on test data for when fastText supervised model support comes (possibly too large, might be replaced by a smaller one if that's an issue).
The workaround for facebookresearch/fastText#218 was also removed, since that issue got fixed upstream (and was related to an external corpus, not to the software itself).