Code-style changes in PR#1248 #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menshikh-iv
reviewed
Jun 8, 2017
docs/notebooks/keras_wrapper.ipynb
Outdated
| @@ -252,7 +217,9 @@ | |||
| "source": [ | |||
| "word_a = 'graph'\n", | |||
| "word_b = 'trees'\n", | |||
| "output = keras_model.predict([np.asarray([model.wv.vocab[word_a].index]), np.asarray([model.wv.vocab[word_b].index])]) # output is the cosine distance between the two words (as a similarity measure)\n", | |||
| "output = keras_model.predict([np.asarray([model.wv.vocab[word_a].index]), np.asarray([model.wv.vocab[word_b].index])])\n", | |||
There was a problem hiding this comment.
Please move comment above this line
There was a problem hiding this comment.
Done. Thanks.
|
Thanks, @chinmayapancholi13. |
|
@chinmayapancholi13 any reason why Variables in Python should be lowercase by convention. |
|
@piskvorky Yes! My apologies that I wasn't vigilant enough for this case. I'll fix this in one of the following related PRs. |
|
No problem :) As long we're converging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements some code-style changes in #1248 as suggested by @piskvorky here.