Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain new concepts introduced in corpus streaming example #1347

Merged
merged 1 commit into from
May 22, 2017

Conversation

oonska
Copy link
Contributor

@oonska oonska commented May 22, 2017

Add paragraph describing dictionary.dfs and dictionary.compactify()

In code snippet 13 there are two new concepts introduced that have not
been explained yet. In addition the workflow to create the dictionary
here is completely different from the workflow described in code
snippets 4 and 5. I've added a paragraph that tries to explain the new
workflow and concepts.

@tmylk
Copy link
Contributor

tmylk commented May 22, 2017

Thanks. Could you please put the explanation before the code? "We are going to ..."

In code snippet 13 there are two new concepts introduced that have not
been explained yet. In addition the workflow to create the dictionary
here is completely different from the workflow described in code
snippets 4 and 5. I've added a paragraph that tries to explain the new
workflow and concepts.
@oonska
Copy link
Contributor Author

oonska commented May 22, 2017

@tmylk Explaination moved.

@tmylk
Copy link
Contributor

tmylk commented May 22, 2017

Thanks!

@tmylk tmylk merged commit b5417af into piskvorky:develop May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants