gensim wrappers single vs double quote issue in windows revsolved

[prakhar2b]

Fix #671 According to discussion, a review of all process calls in gensim wrappers was needed, to make sure the quotes are correct for Windows too.

[tmylk]

Are there any other process calls with thiis issue? would be good to fix them all in one PR

[prakhar2b]

Note: As suggested in this comment in #671 , I reviewed all process calls in gensim wrappers, to make sure the quotes are correct for Windows too.

On a side note, the issue was already solved by making changes in the function convert_input according to the code used by the user who opened the issue, but the same changes applied to other functions and in other wrappers too.

More about single vs double quote in windows here

[tmylk]

Thanks for the pr

[piskvorky]

I think you misunderstood the issue. Windows OS needs double quotes in the strings we pass to it, but that has nothing to do with the changes in this PR.

The changes in this PR are a no-op -- they just reformat the "outer quoting" of Python strings, not their content.

@tmylk did you review there are no other single quotes inside strings being passed to Windows, in the wrappers, tutorials etc?

[prakhar2b]

@piskvorky ok, I really misunderstood it. Now, I understand the issue.

I grepped through all the files, and I found one instance of such pattern- this line

msg = "Command '%s' return non-zero exit status %d" % (cmd, res)

I can assure there are no other such pattern. Thanks.