Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bound computation mistake in author-topic model #1156

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

olavurmortensen
Copy link
Contributor

@olavurmortensen olavurmortensen commented Feb 19, 2017

Noticed a mistake in the bound method of the author-topic model (atmodel). This is a very simple fix.

Basically, I forgot to multiply the expectation over author assignments (np.log(1.0 / len(authors_d))) by the number of words in the document sum(cts), and fixed that in this PR.

This fix changes the bound, only by adding a factor that depends only on the data (constant w.r.t. the model).

…gnments by the number of words in the document.
@tmylk tmylk merged commit 5a7b43e into piskvorky:develop Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants