Pass arguments from build_aomp

[JonChesterfield]

Pass arguments (e.g. nocmake) from build_aomp to components

Forwards the arguments as-is, and skips the install step if any arguments were passed. Allows one to do an incremental build of all the components from the top level script.

I'm not totally sure on the interaction between this and the implicit make && install logic so have gone with preserving existing behaviour. It'll call install if the build succeeded and no arguments were passed.

Thoughts?

[JonChesterfield]

I'm also interested in replacing the exit $rc with return, so that failing to build one component doesn't immediately stop the whole train. Something like:

for COMPONENT in $components ; do
build_aomp_component "$@"
done
if [ $all_good ] ; then
for COMPONENT in $components ; do
build_aomp_component install
done
fi

Same net effect if everything builds, doesn't fail immediately if something is going wrong. That's more drastic than this change, but can be a follow on PR if useful for other people.

[ronlieb]

In general , I like the patch. I have certainly added $* to each component build in the past to do the incremental build. I have noticed that not all build component steps know what a nocmake means. Nonetheless, its an improvement. I assume the usage scenario would be :

./build_aomp.sh nocmake
./build_aomp.sh install

Regarding the change to allow the build to proceed if one component fails: is there some way we can elect this behavior? perhaps a -k option that is consumed ? I prefer the default to be that the build stops on first failure, as I don't want to burn a lot of cycles building if there is an earlier error.

[estewart08]

I would prefer the immediate failure as well because most likely there is a dependency down the line that will fail. It would be nice to have the ability to tell build_aomp.sh which component to continue with when we already have a partial build due to a failure. e.g. (-restart-at )

[JonChesterfield]

Thanks. I'll merge this and give continue-on-failure behaviour a little more thought. Make's -k was the inspiration.